move to event for data loading so it shows up in datapack list #1024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… OUT THE SERVER DOESN'T CALL THIS WTF)
mikerooni
approved these changes
Mar 29, 2024
screret
added a commit
that referenced
this pull request
Mar 30, 2024
… OUT THE SERVER DOESN'T CALL THIS WTF) (#1024)
screret
added a commit
that referenced
this pull request
Mar 30, 2024
* Port multi-amp energy hatches not giving overclocks. (#1009) * port 1.12#2139, 1.12#1741 * run data * fix crash * requested change part 1 Co-authored-by: Mikerooni <[email protected]> * requested changes part 2 --------- Co-authored-by: Mikerooni <[email protected]> * Default predicated buttons to hidden, so buttons don't appear before checking their predicate (#1015) * Fix bucket model (#1008) (#1014) * Fix: processing array accepting multiblock machines (#1013) * fix: Enhance ProcessingArrayMachine no longer use MultiBlock machine controller. * fix: Enhance ProcessingArrayMachine no longer use MultiBlock machine controller. * Optimize access widener and convert to access transformer (#1012) * fix fluid pipes converting an empty fluidstack to an (illegal) null (#1010) * Ordered large distillery outputs (#1021) Defaulted to distillation tower recipes instead of distillery Require 1x output hatches Co-authored-by: sirjoekcb <[email protected]> * Wiremill Circuit Recipes (#1004) * Wiremill Circuit Recipes * Ported the 1.12.2 Wiremill Circuit recipes * Keep wooden form in crafting table after recipe (#923) * fix: always apply OC logic even if amount of OC is 0 so that pyrolyse oven penalties apply. (#1017) * feat: make rubber saplings, leaves compostable (#1018) * fix crash in case of somehow pathing air (#1019) * NO, we DO want to keep the PA deprecated. (#1023) * move to event for data loading so it shows up in datapack list (TURNS OUT THE SERVER DOESN'T CALL THIS WTF) (#1024) * Allow the spray can to paint a chain of blocks at once (#1025) * Allow the spray can to paint a chain of blocks at once * Use MutableBlockPos for chain spray painting * Changed return type of getDurabilityForDisplay from int to float (#1026) * Fixes PA voltage stack overflow on load (#1027) Co-authored-by: sirjoekcb <[email protected]> * add ability to use block/fluid tags in multiblock patterns (#1030) * update, update LDlib, changelog (#1031) * update, update LDlib, changelog * more changelog * Grid UI in multiblock part switcher (#1032) * feat: use a grid UI in the multiblock part switcher * chore: version & changelog * fix errors * don't get resource from mod, return null instead. --------- Co-authored-by: Mikerooni <[email protected]> Co-authored-by: ctrlaltmilk <[email protected]> Co-authored-by: Alendill <[email protected]> Co-authored-by: sirjoekcb <[email protected]> Co-authored-by: sirjoekcb <[email protected]> Co-authored-by: Reclipse <[email protected]> Co-authored-by: Maxim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
server does call it my sources weren't set up
Implementation Details
removes the mixins used for loading assets & data in favor of using the event designed for it.
Outcome
cleaner code, less mixins!
Additional Information
shouldn't cause errors (I haven't tested this yet can someone test it)
Potential Compatibility Issues
none