feat: Subset stage 2: Linear database subset (non circular) bug fixes #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixed wrong join condition by different edges * Introduced Path object - it collects edges and vertexes and isolate them within scope if the edges are the same * Introduced graph object * Refactored DFS algo for finding all subset vertexes and paths
wwoytenko
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
database subset: Increment 2
Though this fixes bugs that were in the first implementation of the subset it still does not fully support circular dependencies resolution.
It is required to implement a condensed graph for circular dependencies and use those condensed edges and vertexes to build a query.
Partially closes #139