-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Appimage builds #28
Appimage builds #28
Conversation
@@ -0,0 +1,3 @@ | |||
#!/bin/sh | |||
CURRENTDIR="$(readlink -f "$(dirname "$0")")" | |||
exec "$CURRENTDIR"/usr/bin/Ryujinx.sh "$@" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not absolutely necessary to create an AppRun, if this is all you are doing. But it can stay in case you want to add more functionality in the future.
otherwise ln -s AppDir/usr/bin/Ryujinx.sh AppDir/AppRun
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think it should stay just in case more functionality wants to be added down the road
PR will fail until PR #31 is merged or you make the formatting and whitespace fixes. And you have to set the path to upload the artifact as PR/Release build. |
The packaging looks good now. Forgot to add earlier, the log files/folder needs to be directed out of the publish folder, now located in The project this is based on used a flag for Flatpak, which had the same issue.
|
uploading appimages to release and PR's
this shouldn't be needed as it should default to |
@qurious-pixel This infra was from myself & @Samueru-sama's changes in ryujinx-mirror. There ended up being issues with just symlinking stuff for |
The appimage works for me including creating the logs folder in The zsync file doesn't need to be included in the zip, and should probably be uploaded as an artifact when published as a release. (to use with AppImageUpdate) @regginator linuxdeploy is more robust at following symlinks, but I have used both tools for different goals. |
added AppImage build files to gitignore
this is why i shouldn't do things after not sleeping
this should in in theory work but i'm unsure, and i'm sure this could be improved