Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appimage builds #28

Merged
merged 10 commits into from
Oct 26, 2024
Merged

Appimage builds #28

merged 10 commits into from
Oct 26, 2024

Conversation

piplup55
Copy link
Contributor

this should in in theory work but i'm unsure, and i'm sure this could be improved

@github-actions github-actions bot added the infra Updates to dependencies label Oct 21, 2024
@@ -0,0 +1,3 @@
#!/bin/sh
CURRENTDIR="$(readlink -f "$(dirname "$0")")"
exec "$CURRENTDIR"/usr/bin/Ryujinx.sh "$@"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not absolutely necessary to create an AppRun, if this is all you are doing. But it can stay in case you want to add more functionality in the future.

otherwise ln -s AppDir/usr/bin/Ryujinx.sh AppDir/AppRun

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think it should stay just in case more functionality wants to be added down the road

@qurious-pixel
Copy link

qurious-pixel commented Oct 21, 2024

PR will fail until PR #31 is merged or you make the formatting and whitespace fixes.
Then your PR should build an AppImage.

And you have to set the path to upload the artifact as PR/Release build.

@qurious-pixel
Copy link

qurious-pixel commented Oct 22, 2024

The packaging looks good now.

Forgot to add earlier, the log files/folder needs to be directed out of the publish folder, now located in AppDir/usr/bin, because it will cause a segfault due to trying to write to a read-only location.

The project this is based on used a flag for Flatpak, which had the same issue.
Should set the Flatpak channel flag, or use custom code to create logs in XDG_DATA_HOME folder.

RYUJINX_TARGET_RELEASE_CHANNEL_OWNER: flathub

uploading appimages to release and PR's
@piplup55
Copy link
Contributor Author

The project this is based on used a flag for Flatpak, which had the same issue. Should set the Flatpak channel flag, or use custom code to create logs in XDG_DATA_HOME folder.

this shouldn't be needed as it should default to $HOME/.config/Ryujinx

@regginator
Copy link

regginator commented Oct 24, 2024

@qurious-pixel This infra was from myself & @Samueru-sama's changes in ryujinx-mirror. There ended up being issues with just symlinking stuff for appimagetool, resulting in non-local AppImage builds simply not working due to invalid symlinks. (Why appimageool doesn't just follow symlinks like normal I have no clue) I'm unsure if AppRun really is necessary, so I'd just leave everything as-is from ryujinx-mirror.

@qurious-pixel
Copy link

qurious-pixel commented Oct 24, 2024

The appimage works for me including creating the logs folder in $HOME/.config/Ryujinx.
The AppRun as designed accomodates running the extracted image, while appimagetool will create a relative symlink to binary if none is provided.

The zsync file doesn't need to be included in the zip, and should probably be uploaded as an artifact when published as a release. (to use with AppImageUpdate)

@regginator linuxdeploy is more robust at following symlinks, but I have used both tools for different goals.

added AppImage build files to gitignore
this is why i shouldn't do things after not sleeping
@GreemDev GreemDev merged commit 5fa7457 into GreemDev:master Oct 26, 2024
Otozinclus pushed a commit to Otozinclus/Ryujinx that referenced this pull request Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra Updates to dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants