-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add language localisation for all missing items #113
Conversation
Remove unused AutoloadDlcAndUpdateAddedMessage
Please, the Google-translated |
Thanks @WilliamWsyHK , I will review and see if I can get Google to use traditional Chinese instead for these. |
Honestly I kinda don't want to merge this at all now. How many other translations are just wrong or bad because of Google Translate? This is why we don't already run everything through online translators, it's never correct. |
Hey @GreemDev , I understand but the main point is that the tool I wrote can easily redo them from scratch, this is just a case of it using Simplified Chinese instead of Traditional, so it’s just a matter of changing the tooling to use traditional instead and I can easily update it. So not a big deal, also it’s only adding missing ones. Not replacing existing. I will update it soon with the correct language, we just need one person from each language to confirm it’s good before we merge. Cheers. |
Hey @WilliamWsyHK & @GreemDev , I have updated the tool to use the correct language translation and regenerated the missing language conversions. You can find the recent changes in a new Pull Request #171 , @WilliamWsyHK can you please confirm these look good now? I have also uploaded the tool itself which you can find here: https://github.com/amurgshere/LanguageLocaliser Thank You. |
Add language localisation for all missing items
Remove unused AutoloadDlcAndUpdateAddedMessage
Created a utilty which uses the publicly accessible Google Translate to find all missing locale items and translate them, the utility preserves all original encoding and translations and only adds the missing ones, please help me to confirm the language conversions are good. I did consider sorting all of them so that the locales are all in alphabetical order of name, but that would have caused us to lose our ability to diff these accurately, so left them in the order they are in as much as possible.
For some reason it is complaining about bidirectional unicode characters, but these were already in there, I can regenerate them and not use the JavaScriptEncoder.UnsafeRelaxedJsonEscaping encoder, but this will then end up modifying a lot of these items using /uxxxx syntax instead which I feel is not ideal.
Will upload the tool I created to GitHub when I get the code cleaned up.