Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global plot defaults wrapper #747

Merged
merged 80 commits into from
Jan 10, 2025
Merged

Global plot defaults wrapper #747

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
80 commits
Select commit Hold shift + click to select a range
9da94b7
created a glaPlot function to handle defaultPlotStyles and take in cu…
halimahLDN Dec 19, 2024
77c5b01
update package-lock
halimahLDN Dec 19, 2024
2ee227b
separated default styles into defaultPlot and defaultMark and exporte…
halimahLDN Dec 19, 2024
36fb865
made options prop optional
halimahLDN Dec 19, 2024
0ea7d1e
spread defaultXScale props
halimahLDN Dec 19, 2024
21b22c7
simplifying passing in marks
halimahLDN Dec 19, 2024
4b54b73
updating types
halimahLDN Dec 19, 2024
f4d12be
importing getDefaultMarkStyles
halimahLDN Dec 19, 2024
bf36c7b
importing glaPlot and using it to create an example chart
halimahLDN Dec 19, 2024
560fc51
replacing Marks with any[] to fix type error for now
halimahLDN Dec 19, 2024
7a7e8ed
adding more descriptive comment to glaPlot
halimahLDN Dec 19, 2024
26f9ee5
deleting unused import
halimahLDN Dec 19, 2024
672b107
clarified comment
halimahLDN Dec 19, 2024
ab8973e
reverting change to getDefaultPlotStyles
halimahLDN Dec 20, 2024
40deb08
adding Plot wrapper to contain default styling for marks
halimahLDN Dec 20, 2024
6bd9a3a
fixing imports
halimahLDN Dec 20, 2024
ea23e42
importing types and removing unused types
halimahLDN Dec 20, 2024
3595198
adding visitorTestMarks and replacing ObservablePlot import with cust…
halimahLDN Dec 20, 2024
6ab8da8
refactored to variadic function to handle variable args as data is op…
halimahLDN Dec 20, 2024
e95f992
added other marks with generic types where necessary to match Observa…
halimahLDN Dec 20, 2024
618e5ce
sorted Plot wrapper functions in alphabetical order
halimahLDN Dec 20, 2024
c44fe1f
adding more marks
halimahLDN Dec 20, 2024
172d4c0
refactoring Plot object to spread ObservablePlot and add modifiers af…
halimahLDN Dec 20, 2024
2d6461a
delete unused types
halimahLDN Dec 20, 2024
3370ae4
updating data
halimahLDN Dec 23, 2024
bf59538
adding all marks to Plot wrapper
halimahLDN Dec 23, 2024
825b2d9
deleting unneeded types
halimahLDN Dec 23, 2024
86c03c5
adding visitor data to demo data but this will need to be removed bef…
halimahLDN Dec 23, 2024
1295c69
importing Plot from observable and adding more to spec for visitors
halimahLDN Dec 23, 2024
2ad9405
adding return
halimahLDN Dec 23, 2024
ee55659
adding all spec and marks for area chart
halimahLDN Dec 23, 2024
625e610
adding lists to demoData
halimahLDN Dec 23, 2024
7fe2b72
adding controls and more interactivity to demo chart
halimahLDN Dec 23, 2024
d446a79
Merge branch 'global-plot-defaults' into global-plot-defaults-wrapper
halimahLDN Dec 23, 2024
1dead94
commenting out mark functions and types that don't have default styling
halimahLDN Dec 23, 2024
9b6837b
merging with global-plot-defaults and removing default styling from t…
halimahLDN Dec 23, 2024
8066dcb
increased spacing around controls
halimahLDN Dec 23, 2024
8800cf9
updating options so it's more generic and spreading in the contents
halimahLDN Dec 23, 2024
4b66ca3
reverting changes to PlotOptions but adding spread operator to overwr…
halimahLDN Dec 23, 2024
4470859
adding args prop to options object to handle any extra props needed t…
halimahLDN Dec 23, 2024
e147b6d
added hexbin map
halimahLDN Dec 23, 2024
07f4d78
moved StackedArea example into separate file
halimahLDN Dec 24, 2024
8a99cf1
removed unused code
halimahLDN Dec 24, 2024
4688875
renamed args to other
halimahLDN Dec 24, 2024
4c2dc8d
updated naming and description
halimahLDN Dec 24, 2024
6698f8d
moved hexbinMap and ScatterPlot examples using glaPlot to separate files
halimahLDN Dec 24, 2024
d75abc9
moved data out of demoData into separate files and now loading hexbin…
halimahLDN Jan 6, 2025
a843118
updated imports
halimahLDN Jan 6, 2025
fda5f21
renaming spec objects and adding args object to Story components
halimahLDN Jan 6, 2025
eb18d47
destructured options to access relevant properties without defining a…
halimahLDN Jan 6, 2025
2b5c128
updated description of example charts
halimahLDN Jan 6, 2025
e34cefc
updated options properties to match glaPlot updates
halimahLDN Jan 6, 2025
92f6327
removed mode from glaPlot
halimahLDN Jan 6, 2025
b0c5324
correcting defaultDot to defaultPoint for point styling
halimahLDN Jan 6, 2025
a97c0bd
removing theme mode from example charts
halimahLDN Jan 6, 2025
5506231
removing theme mode
halimahLDN Jan 6, 2025
0489fd2
removing comment
halimahLDN Jan 6, 2025
61bbb37
updating dot to point so marks show up correctly
halimahLDN Jan 6, 2025
ae6363a
moved fx and fy into size prop
halimahLDN Jan 6, 2025
8051571
replaced top level await with then to fix build error
halimahLDN Jan 8, 2025
f87213d
trying to fix await to .then and process data correctly before export…
halimahLDN Jan 8, 2025
ec87f36
applying glaPlot changes to spec creation
halimahLDN Jan 8, 2025
ad1a1e1
created applyDefaults boolean
halimahLDN Jan 8, 2025
7143213
handling Plot.plot if defaults are applied or not
halimahLDN Jan 8, 2025
64014fa
refactoring glaPlot into plot and exporting inside Plot
halimahLDN Jan 8, 2025
b3eb944
commenting out console log
halimahLDN Jan 8, 2025
81760ab
exporting promise
halimahLDN Jan 8, 2025
9b980f0
importing variable correctly
halimahLDN Jan 8, 2025
7b1d918
remove console.log
ChrisKnightLDN Jan 8, 2025
ebac522
Fix redeclare width caused overwrite
ChrisKnightLDN Jan 8, 2025
72bfdba
added commented code to stories for ease of reference
halimahLDN Jan 9, 2025
0e18f41
Merge branch 'dev' into global-plot-defaults-wrapper
ChrisKnightLDN Jan 9, 2025
f92784e
install after merge
ChrisKnightLDN Jan 9, 2025
e811055
remove old demos - add new data
ChrisKnightLDN Jan 9, 2025
3a8071b
rename plot file and remove glaPlot function
ChrisKnightLDN Jan 9, 2025
3e88a29
remove console.log
ChrisKnightLDN Jan 9, 2025
6b92d3d
fix: lint error
ChrisKnightLDN Jan 10, 2025
3cb1039
remove @turf/rewind dependency
jamesscottbrown Jan 10, 2025
1d5d0d4
minor edits to docstring
jamesscottbrown Jan 10, 2025
03819d9
add changest file
jamesscottbrown Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/plot-wrapper.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'@ldn-viz/charts': major
---

CHANGED: `ObservablePlot` and `ObservablePlotInner` now default to using a wrapper about Observable Plot;s `Plot.plot()` that applies default chart styling
ADDED: wrapper functions that wrap Observable Plot's mark functions and apply default styling
139 changes: 110 additions & 29 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading