Update tooltip with modal #304
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-viz-tools into update-tooltip-with-modal
…London-Authority/ldn-viz-tools into update-tooltip-with-modal
…-viz-tools into update-tooltip-with-modal
|
I need to look at this together with the |
|
@jamesscottbrown ready for review. |
|
@jamesscottbrown when reviewing this - the sidebarHint has a todo against it to implement a popover - see meltUi popover - also implemented in hsds hub. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Adds support for modals to tooltips.
Why?
To ensure long and essential information for layer toggles can be placed somewhere, e.g. Green Spaces layer in https://apps.london.gov.uk/wild-and-free/ requires showing license info and link to the London DataStore.
How is it tested?
Storybook
How is it documented?
Storybook
Is it complete?