add a link card component based on Survey of Londoners #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks fine, though there are a couple of concerns: Naming - there is an existing proto design for a card component that is more consistent with https://open-ui.org/components/card.research/ the component added in this pr is more of a CTA button(?) - though that isn't a suggestion for the name - we can discuss. Styling - the styles applied in the wellbeing project shouldn't be followed really as it's a unicorn. So the rounded corners are probably redundant. Designs will need to be finalised. |
Without this, the width of the body is limited, but the grey background of the placard can fil lthe full width of its parent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
This adds a Card component that is acts as a link.
Why?
This pattern has been used in a few places so far (e.g., Survey of Londoners and Wellbeing Explorer), and I want to use it on the multivariate census explorer too,
Does this introduce new dependencies?
No.
How is it tested?
How is it documented?
Are light and dark themes considered?
Is it complete?
index.js?