Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding option to include additional java_opts #52

Merged
merged 1 commit into from
Nov 4, 2021
Merged

Adding option to include additional java_opts #52

merged 1 commit into from
Nov 4, 2021

Conversation

timdeluxe
Copy link
Contributor

Notes for Reviewers

  • The commit history must be preserved - please use the rebase-merge or standard merge option instead of squash-merge
  • Sync up with the author before merging

malcyon
malcyon suggested changes Nov 4, 2021
View reviewed changes
Copy link

@malcyon malcyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for the PR! I only see one minor thing.

manifests/params.pp Outdated Show resolved Hide resolved
@timdeluxe timdeluxe requested a review from malcyon November 4, 2021 14:13
malcyon
malcyon approved these changes Nov 4, 2021
View reviewed changes
Copy link

@malcyon malcyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I validated this on my local machine, and it looks good! Thanks so much!

@malcyon malcyon merged commit 9345c30 into Graylog2:master Nov 4, 2021
@timdeluxe
Copy link
Contributor Author

@malcyon Any module release planned here, which includes this merge?

@malcyon
Copy link

malcyon commented Aug 3, 2022

I'm not part of the Graylog team anymore. @bernd might be able to take a look at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malcyon malcyon malcyon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timdeluxe @malcyon