Skip to content

Fix 'Shallow Select' mode behavior for selection context transference #2604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
Apr 30, 2025

Conversation

mTvare6
Copy link
Contributor

@mTvare6 mTvare6 commented Apr 21, 2025

Fixes #2392

@Keavon
Copy link
Member

Keavon commented Apr 23, 2025

!build

Copy link

📦 Build Complete for 223e84b
https://04480223.graphite.pages.dev

@Keavon
Copy link
Member

Keavon commented Apr 23, 2025

!build

Copy link

📦 Build Complete for 72f1e6a
https://dd86131c.graphite.pages.dev

@Keavon Keavon changed the title Fix ancestor always returning None during shallow select Fix 'Shallow Select' mode behavior for selection context transference Apr 23, 2025
@Keavon
Copy link
Member

Keavon commented Apr 23, 2025

!build

Copy link

📦 Build Complete for 2738b92
https://e45bcd3b.graphite.pages.dev

@Keavon
Copy link
Member

Keavon commented Apr 24, 2025

!build

Copy link

📦 Build Complete for 7f71507
https://7fedf7dc.graphite.pages.dev

@Keavon
Copy link
Member

Keavon commented Apr 24, 2025

In Valley of Spires, if you click on anything except the sky (since that's not a group), it selects it. Then just single-click it again and it incorrectly deselects it.

@Keavon Keavon marked this pull request as draft April 24, 2025 04:21
@Keavon
Copy link
Member

Keavon commented Apr 24, 2025

!build

Copy link

📦 Build Complete for 484c628
https://b673cba2.graphite.pages.dev

@mTvare6 mTvare6 marked this pull request as ready for review April 24, 2025 11:20
@Keavon
Copy link
Member

Keavon commented Apr 24, 2025

!build

Copy link

📦 Build Complete for 442754b
https://bfd51ad2.graphite.pages.dev

@Keavon
Copy link
Member

Keavon commented Apr 24, 2025

!build

Copy link

📦 Build Complete for 5546ec4
https://d391b9bc.graphite.pages.dev

@Keavon Keavon enabled auto-merge (squash) April 30, 2025 03:21
@Keavon Keavon merged commit 90be1f4 into GraphiteEditor:master Apr 30, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shallow Select mode fails to transfer selection to selected sibling
2 participants