Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show the open hand cursor when space bar is held #2173

Draft
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

pratikagr
Copy link
Contributor

@pratikagr pratikagr commented Jan 3, 2025

  • Introduced the icon Grab for open hand.
  • KeyDown(Command) please change this to Space to see unexpected behavior i am facing, i have used Command just to check the behavior.
  • I have implemented the space key changing icon on hold for now.

https://discord.com/channels/731730685944922173/881073965047636018/940870554574024745

When holding space (but not dragging), the cursor should show the open hand icon (then switch to the currently-implemented closed hand while mousedown/dragging).

@Keavon
Copy link
Member

Keavon commented Jan 12, 2025

!build

Copy link

📦 Build Complete for 6c121d5
https://34799528.graphite.pages.dev

@Keavon
Copy link
Member

Keavon commented Jan 12, 2025

This also will need to work after clicking to drag and then releasing, but keeping Space held down.

@Keavon Keavon marked this pull request as draft January 12, 2025 22:06
@Keavon Keavon changed the title Fix Spacebar Cursor Icon Behavior Show the open hand cursor when space bar is held Jan 12, 2025
@pratikagr
Copy link
Contributor Author

This also will need to work after clicking to drag and then releasing, but keeping Space held down.

please check now

@pratikagr pratikagr marked this pull request as ready for review January 14, 2025 11:31
@Keavon
Copy link
Member

Keavon commented Jan 14, 2025

!build

Copy link

📦 Build Complete for e198945
https://e453c9e7.graphite.pages.dev

@Keavon
Copy link
Member

Keavon commented Jan 14, 2025

After middle click drag, the cursor gets stuck in the dragging state.

@Keavon Keavon marked this pull request as draft January 14, 2025 20:23
@pratikagr pratikagr marked this pull request as ready for review January 16, 2025 06:25
@Keavon
Copy link
Member

Keavon commented Jan 16, 2025

!build

Copy link

📦 Build Complete for 4b6599e
https://7daf31b4.graphite.pages.dev

@Keavon
Copy link
Member

Keavon commented Jan 17, 2025

!build

Copy link

📦 Build Complete for a035f49
https://52e589d4.graphite.pages.dev

@Keavon Keavon force-pushed the master branch 2 times, most recently from 7465fad to ab724d8 Compare January 18, 2025 00:03
@Keavon
Copy link
Member

Keavon commented Jan 24, 2025

!build

Copy link

📦 Build Complete for 76262db
https://e56d6a48.graphite.pages.dev

@Keavon
Copy link
Member

Keavon commented Jan 24, 2025

This isn't working at all. Pressing Space does nothing to the cursor. Please always test before opening for review.

@Keavon Keavon marked this pull request as draft January 24, 2025 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants