Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the Select tool re-select initially selected layers upon pressing Shift during box selection #2171

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

0SlowPoke0
Copy link
Contributor

@0SlowPoke0 0SlowPoke0 commented Jan 1, 2025

Improves Select-Tool as discussed in discord

@0SlowPoke0 0SlowPoke0 force-pushed the shift_select_previous branch 2 times, most recently from 0dd824b to 3cf3cdb Compare January 1, 2025 12:53
@Keavon
Copy link
Member

Keavon commented Jan 1, 2025

!build

Copy link

github-actions bot commented Jan 1, 2025

📦 Build Complete for 3cf3cdb
https://dabb8ba4.graphite.pages.dev

@Keavon
Copy link
Member

Keavon commented Jan 1, 2025

We'll want the introduced Shift functionality to be on a held, not toggle, basis.

@Keavon
Copy link
Member

Keavon commented Jan 6, 2025

!build

Copy link

github-actions bot commented Jan 6, 2025

📦 Build Complete for 0f9ed57
https://44d7ee77.graphite.pages.dev

@Keavon
Copy link
Member

Keavon commented Jan 7, 2025

!build

Copy link

github-actions bot commented Jan 7, 2025

📦 Build Complete for 1e16689
https://d9aa5b95.graphite.pages.dev

@0SlowPoke0 0SlowPoke0 marked this pull request as ready for review January 10, 2025 16:35
@Keavon Keavon force-pushed the shift_select_previous branch from 7e2d510 to 2981512 Compare January 10, 2025 21:38
@Keavon
Copy link
Member

Keavon commented Jan 10, 2025

!build

Copy link

📦 Build Complete for 2981512
https://b2ee5258.graphite.pages.dev

@Keavon Keavon changed the title Re-select Deselected Layers with Shift During Drawing Box Make the Select tool re-select initially selected layers upon pressing Shift during box selection Jan 10, 2025
@Keavon Keavon force-pushed the shift_select_previous branch from 2981512 to 9f865c4 Compare January 13, 2025 02:25
@Keavon
Copy link
Member

Keavon commented Jan 13, 2025

!build

Copy link

📦 Build Complete for 9f865c4
https://2e621456.graphite.pages.dev

@Keavon
Copy link
Member

Keavon commented Jan 13, 2025

See my comment in Discord for an edge case. Marking as draft for the moment.

@Keavon Keavon marked this pull request as draft January 13, 2025 02:49
@0SlowPoke0 0SlowPoke0 force-pushed the shift_select_previous branch 4 times, most recently from d2c7bf0 to 8d6d475 Compare January 13, 2025 17:07
@Keavon Keavon force-pushed the shift_select_previous branch from 8d6d475 to e416ccb Compare January 13, 2025 19:51
@Keavon
Copy link
Member

Keavon commented Jan 13, 2025

!build

@Keavon Keavon marked this pull request as ready for review January 13, 2025 21:26
Copy link

📦 Build Complete for e416ccb
https://14c8b2ad.graphite.pages.dev

@Keavon Keavon marked this pull request as draft January 13, 2025 21:28
@0SlowPoke0 0SlowPoke0 marked this pull request as ready for review January 14, 2025 02:12
@Keavon Keavon marked this pull request as draft January 14, 2025 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants