Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added snap and lock angle feature to path tool #2160

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

added snap and lock angle feature to path tool #2160

wants to merge 5 commits into from
+150 −13

Conversation

bakayu
Copy link
Contributor

@bakayu bakayu commented Dec 24, 2024 •
edited
Loading

Closes #1870 partly...
This PR aims to close the following parts of #1870 :

  • Alt keeps the handles equidistant while pressed (instead of Shift in use now) (Add Path tool support for the Tab key swapping to dragging the opposite handle #2058)
    • It also creates a matching handle if the other is zero-length or not a cubic Bézier
  • Shift locks the handle angle to 15° increments
    • (shouldn't interfere with Shift-clicking handles for multi-selecting points such as handles)
  • Ctrl locks the current angle of the handle

@Keavon
Copy link
Member

Keavon commented Dec 25, 2024

!build

@github-actions GitHub Actions
Copy link

📦 Build Complete for acd7e1e
https://31e24e5f.graphite.pages.dev

bakayu and others added 4 commits December 25, 2024 19:55
@bakayu
fixed breakage of tab and space functionality
566f2f5 
- Previous implementation broke functionality of using Tab to swap the being-dragged handle to its opposing handle, Now fixed.
- Previous implementation broke functionality of using space to drag the manipulator group (anchor + handles) while dragging a handle, Now fixed.
@bakayu
fixed the angle snapping and locking when used together
7cb6a03 
Now, if `shift` is used to snap to a 15° increment, then `ctrl` is used to preserve the angle, releasing the `shift` key will still preserve the angle.
@bakayu
Merge branch 'master' into path-tool-update
9581e8b
@0HyperCube
Fix snapping angle logic
a592509
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tracking Issue: Pen and Path tool improvements
3 participants
@bakayu @Keavon @0HyperCube