Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an editor preference for touched/enclosed/directional based selection #2156

Merged
merged 22 commits into from
Jan 26, 2025

Conversation

pratikagr
Copy link
Contributor

@pratikagr pratikagr commented Dec 23, 2024

Closes #2041

capture

  • added a function is_layer_fully_inside to determine if a layer is fully inside a selection box or not which will eventually helps to select objects in rightward direction.

@Keavon
Copy link
Member

Keavon commented Dec 23, 2024

I'll mark this as a draft until you've also added this to the user preferences dialog, with a choice between "Touched", "Contained", and "By Drag Direction". Please mark it as Ready for Review and ping me when that's ready. Thanks!

@Keavon Keavon marked this pull request as draft December 23, 2024 22:22
@Keavon Keavon changed the title Selection direction Add box selection modes for Touched/Contained/By Drag Direction Dec 23, 2024
@pratikagr pratikagr marked this pull request as ready for review December 29, 2024 11:36
Copy link

📦 Build Complete for 3657795
https://b513d476.graphite.pages.dev

@Keavon
Copy link
Member

Keavon commented Dec 31, 2024

There's a merge conflict, please resolve that and I'll get to QA and code review after that.

@pratikagr
Copy link
Contributor Author

@Keavon please check now.

@Keavon
Copy link
Member

Keavon commented Jan 6, 2025

!build

@Keavon
Copy link
Member

Keavon commented Jan 6, 2025

This doesn't compile.

@pratikagr
Copy link
Contributor Author

This doesn't compile.

Please check now.

@Keavon
Copy link
Member

Keavon commented Jan 8, 2025

!build

Copy link

github-actions bot commented Jan 8, 2025

📦 Build Complete for a5360f2
https://11278c9b.graphite.pages.dev

@Keavon Keavon force-pushed the master branch 2 times, most recently from 7465fad to ab724d8 Compare January 18, 2025 00:03
@Keavon Keavon changed the title Add box selection modes for Touched/Contained/By Drag Direction Add a preference for touched/enclosed/directional selection Jan 26, 2025
@Keavon Keavon changed the title Add a preference for touched/enclosed/directional selection Add an editor preference for touched/enclosed/directional based selection Jan 26, 2025
@Keavon Keavon enabled auto-merge (squash) January 26, 2025 06:33
@Keavon Keavon merged commit 96c5760 into GraphiteEditor:master Jan 26, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Selection direction difference
2 participants