Improve quick measurement overlays with better number alignment and decimal rounding #2155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
singhutsav5502
changed the title
4 tasks
Keavon
reviewed
Dec 23, 2024
|
hi @Keavon just a quick ping, i have pushed the updated code so do review whenever possible. |
Keavon
force-pushed
the
quick_measure_text_alignment
branch
from
deb2717 to
665aa71
Compare
|
!build |
|
|
A couple (or maybe the same?) failing cases:
I'd also like to see up to two decimal places of precision, but only when necessary. So no trailing zeros in the decimals:
|
|
okay! will push the changes ASAP. |
…502/Graphite into quick_measure_text_alignment
|
!build |
|
Keavon
reviewed
Dec 26, 2024
Keavon
reviewed
Dec 26, 2024
|
hi @Keavon, i have pushed the updated code so do review whenever possible. |
Keavon
changed the title
Keavon
approved these changes
Dec 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Further implements #1896, Tidies up number text alignment and decimal precision for quick measure overlays.