-
-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add max width/height to text layers and draggable text boxes to the Text tool #2118
Conversation
1e681f1
to
2ae64a1
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good and it works well. Thanks for this contribution.
I'll do a quick review before this is merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QA feedback:
- Text tool dragging to create a text area:
- Needs support for right-clicking or Escape to abort
- Needs support for holding the Shift modifier to make it draw a constrained square area (try this in the Rectangle tool)
- Needs support for holding the Alt modifier to make it draw centered around the starting point of the drag (try this in the Rectangle tool)
- Needs to work with auto-panning correctly, so the drag starting point doesn't drift
- When the Select tool is active and the text layer is selected, it should display a second rectangle around the text (in addition to the existing interactive transform cage's rectangle) styled with a dashed line, indicating the bounds of the text area so it's clear to the user that the transform cage is affecting the text transform but there is also a separate text area that's not being dragged (until we eventually add some kind of way to let the user choose between dragging the transform vs. the text area width)
- Before we can merge this, we need to write an upgrade script to support the new format which runs when opening a document file. Please see here for the existing code you can reference, which I wrote when I added line height and character spacing.
I'll set this to draft status while waiting on those changes. @Nitish-bot, please mark it was ready for review and ping me in a comment when you've got those resolved. Thank you! |
|
Needed follow-up work:
|
Part of #1105
By the end, you should be able to drag with the text tool to create a bounding box and your line width should be set automatically which was hard coded to none before. Your cursor should also change to reflect change in functionality when dragging.