Gracefully cancel image capture request #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muhomorr
reviewed
Sep 26, 2024
MHShetty
force-pushed
the
capture_cancel
branch
3 times, most recently
from
387cae6 to
33a774f
Compare
(when camera is restarted/stopped)
MHShetty
force-pushed
the
capture_cancel
branch
from
33a774f to
be804fa
Compare
muhomorr
requested changes
Nov 8, 2024
app/src/main/java/app/grapheneos/camera/capturer/ImageCapturer.kt
Outdated
Show resolved
Hide resolved
(to continue saving the image once a capture is successful)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cancels image request in cases when the camera instance restarts (to cover all possible cases such as opening in app gallery, sharing media by long tapping the preview, settings is opened, modes are switched, the side facing is flipped, or any other such case), and when the app gets paused