Replace VideoView with ExoPlayer for VideoPlayer #445
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(over the existing VideoView UI)
(in VideoPlayer.kt)
MHShetty
force-pushed
the
video_back_swipe
branch
9 times, most recently
from
358eef1 to
382d557
Compare
MHShetty
force-pushed
the
video_back_swipe
branch
from
382d557 to
0d4a193
Compare
MHShetty
force-pushed
the
video_back_swipe
branch
4 times, most recently
from
538bb8e to
5addd39
Compare
MHShetty
force-pushed
the
video_back_swipe
branch
from
5addd39 to
28e80d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces Android's existing in-built VideoView with AndroidX's Media3 ExoPlayer.
The new Exoplayer solves multiple issues present with VideoView, including the issue of being unable to often move out of the VideoPlayer in a single back swipe gesture (described in #261), and adds new controls to the video player.