port setting ui to mateiral3 using androidx preference #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
empratyush
force-pushed
the
settings-cleanup-14-01-24
branch
7 times, most recently
from
aa2ef21 to
d905845
Compare
|
Tested manually on Pixel 7 pro, Pixel 8. |
|
image/video format setting was unused, it has been dropped. |
empratyush
force-pushed
the
settings-cleanup-14-01-24
branch
6 times, most recently
from
1b19bb2 to
5c9b6d5
Compare
empratyush
force-pushed
the
settings-cleanup-14-01-24
branch
3 times, most recently
from
25e66c6 to
6222103
Compare
empratyush
force-pushed
the
settings-cleanup-14-01-24
branch
3 times, most recently
from
e37ba8c to
e92e9de
Compare
|
rebase on latest main branch. |
These default values are used by the preference screen hardcoding default values manually is error-prone.
empratyush
force-pushed
the
settings-cleanup-14-01-24
branch
from
e92e9de to
4599cbf
Compare
|
This has been implemented. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.