bug fix for MMWrite (invalid output on array format) #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minor build updates for LAGraph 1.1.1
LAGraph 1.1.2: minor updates to build system
for array format, the first non-comment line must contain just two integers
|
Yes, that's a bug. Thanks for catching that. I changed the PR to make it for the v1.1_branch since stable branch is protected against PRs. The most recent development version is on the v1.2 branch, but the CI is currently failing there. The v1.2 branch is very different than v1.1; I tried to rebase to that but there were too many unrelated changes. |
DrTimothyAldenDavis
added a commit
that referenced
this pull request
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into this bug yesterday when you write a dense matrix to a file using the
LAGraph_MMWrite, the pythonscipy.io.mminfofunction starts complaining when you read the file. This is because the array format is used when you write a dense matrix, but theMMWritefunction still outputs the number of entries. This behavior should be different for the array format than for the coordinate format.I consulted both the MatrixMarket format documentation, as well as your documentation (https://lagraph.readthedocs.io/en/latest/utils.html#array-format). It seems to agree that this is not correct behavior and Scipy has the right to scream. A quote from your documentation: For array format, the first non-comment line must appear, and it must contain just two integers
I hope I formatted everything correctly, let me know if I need to change anything.