full test coverage

GraphBLAS · Dec 5, 2023 · a92165c · a92165c
1 parent de51a91
commit a92165c
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/src/test/test_Xinit.c b/src/test/test_Xinit.c
@@ -61,7 +61,7 @@ void test_Xinit (void)
 //------------------------------------------------------------------------------
 
 #if LAGRAPH_SUITESPARSE
-bool LG_init_has_been_called_from_Xinit ;
+bool LG_init_has_been_called ;
 void test_Xinit_brutal (void)
 {
     // no brutal memory failures, but test LG_brutal_malloc/calloc/realloc/free
@@ -131,7 +131,7 @@ void test_Xinit_brutal (void)
     {
         LG_brutal = nbrutal ;
         GB_Global_GrB_init_called_set (false) ;
-        LG_init_has_been_called_from_Xinit = false ;
+        LG_init_has_been_called = false ;
         int result = LAGr_Init (GrB_NONBLOCKING,
             LG_brutal_malloc, LG_brutal_calloc,
             LG_brutal_realloc, LG_brutal_free, msg) ;

diff --git a/src/test/test_minmax.c b/src/test/test_minmax.c
@@ -227,10 +227,13 @@ void test_minmax (void)
         {
             TEST_CHECK (result == GrB_SUCCESS) ;
         }
+
+        #if 0
         if (emin1 != emin2)
         {
             // failure on MSVC, OpenMP
             // https://github.com/DrTimothyAldenDavis/SuiteSparse/actions/runs/6763376325/job/18380420493?pr=503
+            // now fixed.
             printf ("Test failure, k: %d name: %s\n", k, aname) ;
             printf ("emin1: %30.20g\n", emin1) ;
             printf ("emin2: %30.20g\n", emin2) ;
@@ -245,6 +248,8 @@ void test_minmax (void)
             printf ("emax2 int64: %" PRId64 "\n", emax2_int64) ;
 
         }
+        #endif
+
         TEST_CHECK (emin1 == emin2) ;
 
         result = GrB_Scalar_extractElement_FP64 (&emax2, G->emax) ;