Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor sorter #6149

Draft
wants to merge 48 commits into
base: dev
Choose a base branch
from
Draft

Refactor sorter #6149

wants to merge 48 commits into from

Conversation

mohamedsalem401
Copy link
Member

@mohamedsalem401 mohamedsalem401 commented Sep 16, 2024 •
edited
Loading

  • Split the sorter into multiple classes.
  • Fix the issue with the StyleManager.

Current TODO's

  • ensure good performance

Pre-Merge Checklist:

  • Canvas drag and drop
  • Style manager properties
  • Layers
  • Blocks
  • Sorter event triggering: Is the sorter triggering events as expected (e.g., sorter:drag:start)?
  • Dropping image into the canvas
  • D&D multiple components
  • Rollback button
  • Textable component D&D

@mohamedsalem401
Add canMove and getChildren to Sorter
8c6cbdb
@mohamedsalem401
Make the canvas use Components.canMove function
9d711e7
@mohamedsalem401
Fix StyleManager issue
4c81586
@mohamedsalem401
Make Sorter dependent on an abstract datastructure
21e4ca2
@mohamedsalem401
Remove unneeded properties
85c9dab
@mohamedsalem401
Add drag direction enum
185ef8d
@mohamedsalem401
extract method
19e7145
@mohamedsalem401
Add default values for the sorter
67e2e71
@mohamedsalem401
reverse avoidSelectOnEnd
3638a8a
@mohamedsalem401
Group related options for the Sorter
20c7990
@mohamedsalem401
Fix types, and fix canvas sorter
f8088e5
@mohamedsalem401
Add method to clear source element freeze
c62ab28
@mohamedsalem401
Add DropLocationDeterminer class
4f17832
@mohamedsalem401
Refactor some methods in the sorter
37cc27b
@mohamedsalem401
Refactor endMove method
d27af86
@mohamedsalem401
Refactor rollback method
332bec7
@mohamedsalem401
Merge branch 'dev' of https://github.com/GrapesJS/grapesjs into refac…
726dbdf 
…tor-sorter
@mohamedsalem401
Add DropLocationDeterminer, refactor methods in Sorter class
1d0e52d
@mohamedsalem401
Break the sorter into multiple classes
8c94152
@mohamedsalem401
Fix placeholder class jsdocs
99edd1e
@mohamedsalem401
Fix bug while dropping items near the border
fb2b4c0
@mohamedsalem401
Refactor DropLocationDeterminer
69fc8ea
@mohamedsalem401
Add helping methods to the ComponentSorter
8fd7ed9
@mohamedsalem401
Remove unwanted fields in DropLocationDeterminer
f17d164
@mohamedsalem401
Add componentSorter Class
e3e16c0
@mohamedsalem401
Refactor DropLocationDeterminer Class
6729c33
@mohamedsalem401
Rename file
0037371
@mohamedsalem401
Fix style manager class
c459498
@mohamedsalem401
Move files into a new folder
90cf6ea
@mohamedsalem401
Move types to a new file
ef40cea
@mohamedsalem401
Add back the tree class paramater instead of abstract classes
d289046
@mohamedsalem401
Fix dropping on the same collection issue
45da2af
@mohamedsalem401
refactor isInFlow
014da81
@mohamedsalem401
Change methods to be accessor methods
3ce4cef
@mohamedsalem401
Make component sorter dependant on an abstract node
7e0becc
@mohamedsalem401
Fix bug with dropping into an element with no children
8dab8a2
@mohamedsalem401
Fix component layers drag and drop
34ea415
@mohamedsalem401
Remove the ensure placeholder logic from the StyleManagerSorter
2266283
@mohamedsalem401
Refactor event handler types
ee78ed2
@mohamedsalem401
export interface SorterEventHandlers
a81dbb8
@mohamedsalem401
change to ensurePlaceholderElement method
de9cf1c
@mohamedsalem401
Make images droppable
7281828
@mohamedsalem401
Add support for dragging and dropping textable components
f2ed0b1
@mohamedsalem401
Remove container argument from startSort
88d91c9
@mohamedsalem401
Trigger events on starting and ending the dragging
a5db2fe
@mohamedsalem401
Add triggering old events and callback functions
2b8b2bd
@mohamedsalem401
Fix drop issue with the style manager
150a1e6
@mohamedsalem401
Add cancelling the dragging
e6e9c2f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mohamedsalem401