Relax requirement pinning to accept higher ckanext-dcat versions #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ckanext-dcat 1.7.0 has been released and there is still no fix, 6.7.0 is needlessly outdated again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can't install ckanext-dcatde alongside the recently released ckanext-dcat 1.6.0 due to the strict version pinning. This PR relaxes the version pinning from a strictly pinned version to 1.5.1 and any later version.
I've tested the installation successfully on a CKAN 2.10.3 instance.
Assuming semver is used, '>=' will not ensure compatibility, but since it is used for all other requirements, I didn't want to divert from the current style. Semantically my PR is to switch to
ckanext>=1.5.1,==1.*(or~=1.5if a downgrade to 1.5.0 is not a problem, but I didn't disect the history to see what was the reason for the strict 1.5.1).