Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix builds with Rust 1.79 #3487

Merged
merged 2 commits into from
Jun 17, 2024
Merged

Fix builds with Rust 1.79 #3487

merged 2 commits into from
Jun 17, 2024

Conversation

djmitche
Copy link
Collaborator

corrosion-rs/corrosion#501 required some updates once 1.79 came out (yesterday).

This both

  • Updates the crate's library name to use underscores (which fixes the issue), and
  • Updates corrosion to 0.5.0 (which would also have fixed the issue, and is a good idea anyway)

@djmitche djmitche linked an issue Jun 14, 2024 that may be closed by this pull request
/usr/bin/ld: cannot find -ltaskchampion-lib #3485
Closed
@djmitche djmitche requested a review from felixschurk June 14, 2024 18:09
@felixschurk felixschurk merged commit 82e645b into GothenburgBitFactory:develop Jun 17, 2024
13 checks passed
@chenrui333 chenrui333 mentioned this pull request Jun 17, 2024
Merged
1 task
direc85 pushed a commit to direc85/sailfish-taskwarrior that referenced this pull request Jul 12, 2024
@djmitche @direc85
Fix builds with Rust 1.79 (GothenburgBitFactory#3487)
b1e4b1d 
* use underscore in taskchampion-lib name

* update to corrosion 0.5.0
direc85 pushed a commit to direc85/sailfish-taskwarrior that referenced this pull request Jul 12, 2024
@djmitche @direc85
Fix builds with Rust 1.79 (GothenburgBitFactory#3487)
7222e58 
* use underscore in taskchampion-lib name

* update to corrosion 0.5.0

(cherry picked from commit 82e645b)
@djmitche djmitche mentioned this pull request Oct 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixschurk felixschurk felixschurk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

/usr/bin/ld: cannot find -ltaskchampion-lib
2 participants
@djmitche @felixschurk