Editor: don't alter browser history with page persistence #5321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxyinger
changed the title
maxyinger
requested review from
BrittanyIRL,
carloskelly13,
embarks,
swissspidy and
zachhale
|
Size Change: +34 B (0%) Total Size: 1.44 MB ℹ️ View Unchanged
|
|
Thank you! |
Codecov Report
@@ Coverage Diff @@
## main #5321 +/- ##
==========================================
+ Coverage 76.37% 76.50% +0.13%
==========================================
Files 962 962
Lines 16886 16886
==========================================
+ Hits 12896 12919 +23
+ Misses 3990 3967 -23
Flags with carried forward coverage won't be shown. Click here to find out more.
|
carloskelly13
approved these changes
Nov 17, 2020
There was a problem hiding this comment.
This looks good and keeps the correct page on navigation, I can't think of an offhand reason this would break anything, but would be great for @swissspidy and @barklund to give it a spot check.
embarks
approved these changes
Nov 18, 2020
swissspidy
added
Type: Bug
divyarajmasani
pushed a commit
to rtCamp/web-stories-wp
that referenced
this pull request
Nov 26, 2020
swissspidy
changed the title
swissspidy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Makes hash updates not effect browser history.
Relevant Technical Choices
Moved to using
history.replaceState(...)vs editing the hash directly. This keeps the app from altering history when editing persistent hash state.To-do
NA
User-facing changes
Now when you change pages in the editor, then press the back button in the browser, you should be taken back to the last page you were on before the editor
Testing Instructions
Go to my stories -> open a story in the editor -> click to view several different pages in your story or add a page -> press the browser's back button once -> should go directly back to the stories view.
Fixes #4858