Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workspace: Page hash causes issues with browser history #4858

Closed
swissspidy opened this issue Oct 9, 2020 · 3 comments · Fixed by #5321
Closed

Workspace: Page hash causes issues with browser history #4858

swissspidy opened this issue Oct 9, 2020 · 3 comments · Fixed by #5321
Labels
Group: Workspace A group encompassing all of workspace – everything inside the canvas and sidebar P1 High priority, must do soon Type: Bug Something isn't working

Comments

@swissspidy
Copy link
Collaborator

Bug Description

This is a follow-up to #4605.

Due to the page ID being persisted in the address bar, I cannot reliably use the back button in my browser anymore.

Not sure if this can be easily resolved.

Storing the current page as a hash like this was originally suggested in #825. But maybe we should just use localStorage?

Expected Behaviour

  1. Click on "Add New" in the admin menu.
  2. Click on "Back" button in browser.
  3. Get back to previous page.

Steps to Reproduce

  1. Click on "Add New" in the admin menu.
  2. Notice the URL in the address bar looks like wp-admin/post-new.php?post_type=web-story#page=%2522a69b45a9-8cd9-46c2-b6a0-81f76005ba26%2522
  3. Click on "Back" button in browser.
  4. Notice that nothing happens, except for the URL changing to wp-admin/post-new.php?post_type=web-story#page=null
  5. Click on "Back" button in browser.
  6. Notice that nothing happens, except for the URL changing to wp-admin/post-new.php?post_type=web-story
  7. Click on "Back" button in browser.
  8. Finally you are back on your previous page.

Screenshots

Additional Context

  • Plugin Version: 1.1.0-alpha
  • Operating System: macOS
  • Browser: Chrome 85

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance Criteria

Implementation Brief
@swissspidy swissspidy added Type: Bug Something isn't working P1 High priority, must do soon Pod: Pea Group: Workspace A group encompassing all of workspace – everything inside the canvas and sidebar labels Oct 9, 2020
@swissspidy
Copy link
Collaborator Author

FYI @carlos-kelly @o-fernandez I created this follow-up ticket to #4605. Basically did UAT on it by accident and thought that this is quite annoying.

@bmattb bmattb added this to the Sprint 41 milestone Nov 3, 2020
@maxyinger maxyinger self-assigned this Nov 13, 2020
@maxyinger maxyinger mentioned this issue Nov 16, 2020
Merged
@bmattb bmattb modified the milestones: Sprint 41, Sprint 42 Nov 16, 2020
@csossi
Copy link

csossi commented Nov 20, 2020

Verified in QA

@swissspidy swissspidy reopened this Nov 20, 2020
@samitron7
Copy link

Verified in UAT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Group: Workspace A group encompassing all of workspace – everything inside the canvas and sidebar P1 High priority, must do soon Type: Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Editor: don't alter browser history with page persistence GoogleForCreators/web-stories-wp
5 participants
@swissspidy @samitron7 @csossi @maxyinger @bmattb