Update docs based on code review comments

GoogleContainerTools · May 9, 2019 · 4db921f · 4db921f
1 parent f120c95
commit 4db921f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/docs/content/en/docs/how-tos/builders/_index.md b/docs/content/en/docs/how-tos/builders/_index.md
@@ -295,8 +295,11 @@ custom:
         file: foo
 ```
 
-##### Custom Command
-Skaffold can execute a custom command, which will return dependencies for the artifact.
+##### Getting depedencies from a command
+Sometimes you might have a builder that can provide the dependencies for a given artifact.
+For example bazel has the `bazel query deps` command.
+Custom artifact builders can ask Skaffold to execute a custom command, which Skaffold can use to get the dependencies for the artifact for file watching.
+
 The command *must* return dependencies as a JSON array, otherwise skaffold will error out.
 
 For example, the following configuration is valid, as executing the dependency command returns a valid JSON array.

diff --git a/pkg/skaffold/schema/validation/validation_test.go b/pkg/skaffold/schema/validation/validation_test.go
@@ -391,7 +391,7 @@ func TestValidateCustomDependencies(t *testing.T) {
 		}, {
 			description: "ignore in conjunction with command",
 			dependencies: &latest.CustomDependencies{
-				Command: "bazel query",
+				Command: "bazel query deps",
 				Ignore:  []string{"ignoreme"},
 			},
 			expectedErrors: 1,