Merge pull request #2102 from balopat/v02900

cut v0.29.0

CHANGELOG.md

@@ -1,3 +1,75 @@
+# v0.29.0 Release - 05/09/2019
+
+*Note*: This release comes with a new config version `v1beta10`.
+        To upgrade your `skaffold.yaml`, use `skaffold fix`. If you don't upgrade, skaffold will auto-upgrade in memory as best it can, and print a warning message.
+        See [deprecation-policy.md](/deprecation-policy.md) for details on what beta means.
+
+New Features: 
+
+* Add command to custom artifact dependencies [#2095](https://github.com/GoogleContainerTools/skaffold/pull/2095)
+* Improve syntax for artifact.sync config [1/3] [#1847](https://github.com/GoogleContainerTools/skaffold/pull/1847)
+* Add dockerfile to custom dependencies [#2049](https://github.com/GoogleContainerTools/skaffold/pull/2049)
+* Automatically watch helm subcharts when skipBuildDependencies is enabled [#1371](https://github.com/GoogleContainerTools/skaffold/pull/1371)
+* Allow environment variables to be used in docker build argument [#1912](https://github.com/GoogleContainerTools/skaffold/pull/1912)
+* Add option to configure the networking stack in docker build [#2036](https://github.com/GoogleContainerTools/skaffold/pull/2036)
+* Allow --no-cache to be passed to docker [#2054](https://github.com/GoogleContainerTools/skaffold/pull/2054)
+* Deploy to  consume build output [#2001](https://github.com/GoogleContainerTools/skaffold/pull/2001)
+* Add k8 style managed by label to skaffold deployed pods [#2055](https://github.com/GoogleContainerTools/skaffold/pull/2055)
+* Support kubectl deploy absolute manifest files [#2011](https://github.com/GoogleContainerTools/skaffold/pull/2011)
+
+Bug Fixes:
+
+* Add custom artifact for custom local builds [#1999](https://github.com/GoogleContainerTools/skaffold/pull/1999)
+* Add version as unknown if version.Get().Version is empty [#2097](https://github.com/GoogleContainerTools/skaffold/pull/2097)
+* Fix image release process: master -> edge, tag -> latest [#2099](https://github.com/GoogleContainerTools/skaffold/pull/2099)
+* :bug: fix kubectl apply error handling [#2076](https://github.com/GoogleContainerTools/skaffold/pull/2076)
+* Remove podname from port forward key [#2047](https://github.com/GoogleContainerTools/skaffold/pull/2047)
+* Correctly parse env-var for multi-valued flags [#2032](https://github.com/GoogleContainerTools/skaffold/pull/2032)
+
+Updates & refactoring: 
+
+* Prefix Skaffold labels with 'skaffold-' [#2062](https://github.com/GoogleContainerTools/skaffold/pull/2062)
+* Remove copy paste deploy_test.go [#2085](https://github.com/GoogleContainerTools/skaffold/pull/2085)
+* Freeze v1beta9 config [#2035](https://github.com/GoogleContainerTools/skaffold/pull/2035)
+* Add unit test for port forwarding key [#2059](https://github.com/GoogleContainerTools/skaffold/pull/2059)
+* Refactor kaniko builder to cluster builder [#2037](https://github.com/GoogleContainerTools/skaffold/pull/2037)
+* Attaching os standard error and out stream to the copy command [#1960](https://github.com/GoogleContainerTools/skaffold/pull/1960)
+
+Docs updates:
+
+* Mention kind in docs for local development [#2090](https://github.com/GoogleContainerTools/skaffold/pull/2090)
+* Clarify which containers are port forwarded [#2078](https://github.com/GoogleContainerTools/skaffold/pull/2078)
+* Improve nodejs example to show subdirectories sync [#2024](https://github.com/GoogleContainerTools/skaffold/pull/2024)
+* Minor fix on Markdown to follow markdown rules [#2052](https://github.com/GoogleContainerTools/skaffold/pull/2052)
+* Note filesync limitation for files not owned by container user [#2041](https://github.com/GoogleContainerTools/skaffold/pull/2041)
+
+Design proposals: 
+
+* Design proposal for sync improvements [#1844](https://github.com/GoogleContainerTools/skaffold/pull/1844)
+
+
+Huge thanks goes out to all of our contributors for this release:
+
+- Balint Pato
+- Brian de Alwis
+- Byungjin Park
+- Charles-Henri GUÉRIN
+- Cornelius Weig
+- David Gageot
+- Dmitri Moore
+- Ilyes Hammadi
+- Nick Kubala
+- peter
+- Pierre-Yves Aillet
+- Prashant Arya
+- Priya Wadhwa
+- Rahul Sinha
+- robertrbruno
+- Tejal Desai
+- Tigran Tch
+- Xiaoxi He
+
+
 # v0.28.0 Release - 04/25/2019
 
 *Note*: This release comes with a new config version `v1beta9`.

examples/bazel/skaffold.yaml

@@ -1,4 +1,4 @@
-apiVersion: skaffold/v1beta9
+apiVersion: skaffold/v1beta10
 kind: Config
 build:
   artifacts:

examples/getting-started/skaffold.yaml

@@ -1,4 +1,4 @@
-apiVersion: skaffold/v1beta9
+apiVersion: skaffold/v1beta10
 kind: Config
 build:
   artifacts:

examples/helm-deployment/skaffold.yaml

@@ -1,4 +1,4 @@
-apiVersion: skaffold/v1beta9
+apiVersion: skaffold/v1beta10
 kind: Config
 build:
   tagPolicy:

examples/jib-multimodule/skaffold.yaml

@@ -1,4 +1,4 @@
-apiVersion: skaffold/v1beta9
+apiVersion: skaffold/v1beta10
 kind: Config
 build:
   artifacts:

examples/jib/skaffold.yaml

@@ -1,4 +1,4 @@
-apiVersion: skaffold/v1beta9
+apiVersion: skaffold/v1beta10
 kind: Config
 build:
   artifacts:

examples/kaniko-local/skaffold.yaml

@@ -1,4 +1,4 @@
-apiVersion: skaffold/v1beta9
+apiVersion: skaffold/v1beta10
 kind: Config
 build:
   artifacts:

examples/kaniko/skaffold.yaml

@@ -1,4 +1,4 @@
-apiVersion: skaffold/v1beta9
+apiVersion: skaffold/v1beta10
 kind: Config
 build:
   artifacts:

examples/kustomize/skaffold.yaml

@@ -1,4 +1,4 @@
-apiVersion: skaffold/v1beta9
+apiVersion: skaffold/v1beta10
 kind: Config
 deploy:
   kustomize: {}

examples/microservices/skaffold.yaml

@@ -1,4 +1,4 @@
-apiVersion: skaffold/v1beta9
+apiVersion: skaffold/v1beta10
 kind: Config
 build:
   artifacts:

examples/nodejs/backend/Dockerfile

@@ -1,8 +1,10 @@
 FROM node:8.12.0-alpine
 
+ARG SCRIPT
+ENV SCRIPT ${SCRIPT}
 WORKDIR /opt/backend
 EXPOSE 3000
-CMD ["npm", "run", "dev"]
+CMD ["npm", "run", ${SCRIPT}]
 
 COPY . .
 RUN npm install

examples/nodejs/backend/src/index.js

@@ -1,8 +1,8 @@
-const express = require("express");
-const { echo } = require("./utils");
-const app = express();
-const port = 3000;
+const express = require('express')
+const { echo } = require('./utils');
+const app = express()
+const port = 3000
 
-app.get("/", (req, res) => res.send(echo("Hello World!")));
+app.get('/', (req, res) => res.send(echo('Hello World!')))
 
-app.listen(port, () => console.log(`Example app listening on port ${port}!`));
+app.listen(port, () => console.log(`Example app listening on port ${port}!`))

examples/nodejs/backend/src/utils/index.js

@@ -1,7 +1,7 @@
 function echo(string) {
-  return string;
+    return string;
 }
 
 module.exports = {
-  echo
-};
+    echo
+}

examples/nodejs/skaffold.yaml

@@ -4,12 +4,15 @@ build:
   artifacts:
   - image: gcr.io/k8s-skaffold/node-example
     context: backend
+    docker:
+      buildArgs:
+        SCRIPT: "{{.SCRIPT}}"
     sync:
       manual:
-        # Sync all the javascript files that are in the src folder
-        # with the container src folder
-        - src: 'src/**/*.js'
-          dest: .
+      # Sync all the javascript files that are in the src folder
+      # with the container src folder
+      - src: 'src/**/*.js'
+        dest: .
 deploy:
   kubectl:
     manifests:

examples/react-reload/skaffold.yaml

@@ -1,4 +1,4 @@
-apiVersion: skaffold/v1beta9
+apiVersion: skaffold/v1beta10
 kind: Config
 build:
   artifacts:

examples/structure-tests/skaffold.yaml

@@ -1,4 +1,4 @@
-apiVersion: skaffold/v1beta9
+apiVersion: skaffold/v1beta10
 kind: Config
 build:
   artifacts:

examples/tagging-with-environment-variables/skaffold.yaml

@@ -1,4 +1,4 @@
-apiVersion: skaffold/v1beta9
+apiVersion: skaffold/v1beta10
 kind: Config
 build:
   artifacts: