Check Maven user properties with highest precedence when fetching a property value #4345
+208
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gcbrun |
ldetmer
reviewed
Mar 11, 2025
| */ | ||
| @Nullable | ||
| public static String getProperty( | ||
| String propertyName, @Nullable MavenProject project, @Nullable MavenSession session) { | ||
| if (session != null && session.getSystemProperties().containsKey(propertyName)) { | ||
| return session.getSystemProperties().getProperty(propertyName); | ||
| if (session != null && session.getUserProperties().containsKey(propertyName)) { |
There was a problem hiding this comment.
can getUserProperties be null? if so can you please add null check too?
There was a problem hiding this comment.
ldetmer
reviewed
Mar 11, 2025
jib-maven-plugin/CHANGELOG.md
Outdated
| @@ -4,6 +4,7 @@ All notable changes to this project will be documented in this file. | |||
| ## [unreleased] | |||
|
|
|||
| ### Added | |||
| - Check Maven user properties with highest precedence when fetching a property value ([#4344](https://github.com/GoogleContainerTools/jib/issues/4344)) | |||
There was a problem hiding this comment.
please update to
"Update retrieval of maven properties to use the following order: user, project, system"
There was a problem hiding this comment.
I've updated the changelog via breun@fba991f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4344 🛠️