-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor setting up network storage and run setup network storage as root #119
Open
harshthakkar01
wants to merge
2
commits into
master
Choose a base branch
from
slurm-sync-service
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshthakkar01
force-pushed
the
slurm-sync-service
branch
4 times, most recently
from
May 2, 2024 20:48
983fdab
to
0fa41ba
Compare
harshthakkar01
changed the title
Run slurm sync script as root user and run network storage function
Refactor setting up network storage and run slurm sync script as root user
May 2, 2024
harshthakkar01
force-pushed
the
slurm-sync-service
branch
8 times, most recently
from
May 3, 2024 22:31
7d7a7de
to
68591ab
Compare
harshthakkar01
changed the title
Refactor setting up network storage and run slurm sync script as root user
Refactor setting up network storage and run slurm sync script as root user
May 3, 2024
harshthakkar01
force-pushed
the
slurm-sync-service
branch
from
May 6, 2024 18:48
68591ab
to
9a2db84
Compare
harshthakkar01
force-pushed
the
slurm-sync-service
branch
5 times, most recently
from
May 8, 2024 06:26
24b5d84
to
5e19f9d
Compare
harshthakkar01
changed the title
Refactor setting up network storage and run slurm sync script as root user
Refactor setting up network storage and run setup network storage as root
May 8, 2024
harshthakkar01
force-pushed
the
slurm-sync-service
branch
from
May 8, 2024 17:57
5e19f9d
to
4829eba
Compare
harshthakkar01
commented
May 8, 2024
harshthakkar01
force-pushed
the
slurm-sync-service
branch
from
May 9, 2024 01:32
4829eba
to
38e4d4c
Compare
mr0re1
previously approved these changes
May 9, 2024
harshthakkar01
force-pushed
the
slurm-sync-service
branch
3 times, most recently
from
May 9, 2024 20:46
9f9aa2c
to
bcf2a0d
Compare
harshthakkar01
force-pushed
the
slurm-sync-service
branch
from
May 9, 2024 20:57
bcf2a0d
to
7c180c3
Compare
tpdownes
reviewed
May 10, 2024
harshthakkar01
force-pushed
the
slurm-sync-service
branch
6 times, most recently
from
May 15, 2024 18:21
2cfef6f
to
6bede70
Compare
harshthakkar01
force-pushed
the
slurm-sync-service
branch
from
May 20, 2024 20:17
6bede70
to
cd86595
Compare
harshthakkar01
force-pushed
the
slurm-sync-service
branch
from
May 20, 2024 22:51
cd86595
to
9513e2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following.
setup_network_storage
function andsetupnfs-exports
into separate file.setup_nfs_exports
in the controller during reconfigure.Manual testing
Deployed a cluster without any network storage and then reconfigured after adding new storage.
Filesystems were mounted.