Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor setting up network storage and run setup network storage as root #119

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

harshthakkar01
Copy link
Contributor

@harshthakkar01 harshthakkar01 commented May 1, 2024

This PR does the following.

  • Refactor setup_network_storage function and setupnfs-exports into separate file.
  • Adds wrapper around setup-network-storage package to run it as root.
  • Gives slurm user permission to run bash scripts as root.
  • During setup_network_storage stage, fetches new config from the local. If used like previously, it would fetch old config.
  • Also from the discussion with SchedMD people, it was mentioned to also run setup_nfs_exports in the controller during reconfigure.

Manual testing

Deployed a cluster without any network storage and then reconfigured after adding new storage.

INFO: Waiting for '/test2' to be mounted...
INFO: Waiting for '/test' to be mounted...
INFO: Mount point '/test2' was mounted.
INFO: Mount point '/test' was mounted.

Filesystems were mounted.


Filesystem              Size  Used Avail Use% Mounted on
devtmpfs                8.3G     0  8.3G   0% /dev
tmpfs                   8.3G     0  8.3G   0% /dev/shm
tmpfs                   8.3G  8.9M  8.3G   1% /run
tmpfs                   8.3G     0  8.3G   0% /sys/fs/cgroup
/dev/sda2                54G   11G   44G  20% /
/dev/sda1               210M  6.1M  204M   3% /boot/efi
tmpfs                   1.7G     0  1.7G   0% /run/user/0
tmpfs                   1.7G     0  1.7G   0% /run/user/3672659445
10.137.60.82:/nfsshare  1.1T     0  1.1T   0% /test
10.45.3.250:/nfsshare   1.1T     0  1.1T   0% /test2

@harshthakkar01 harshthakkar01 self-assigned this May 1, 2024
@harshthakkar01 harshthakkar01 force-pushed the slurm-sync-service branch 4 times, most recently from 983fdab to 0fa41ba Compare May 2, 2024 20:48
@harshthakkar01 harshthakkar01 changed the title Run slurm sync script as root user and run network storage function Refactor setting up network storage and run slurm sync script as root user May 2, 2024
@harshthakkar01 harshthakkar01 force-pushed the slurm-sync-service branch 8 times, most recently from 7d7a7de to 68591ab Compare May 3, 2024 22:31
@harshthakkar01 harshthakkar01 changed the title Refactor setting up network storage and run slurm sync script as root user Refactor setting up network storage and run slurm sync script as root user May 3, 2024
@harshthakkar01 harshthakkar01 marked this pull request as ready for review May 3, 2024 22:37
@harshthakkar01 harshthakkar01 force-pushed the slurm-sync-service branch 5 times, most recently from 24b5d84 to 5e19f9d Compare May 8, 2024 06:26
@harshthakkar01 harshthakkar01 changed the title Refactor setting up network storage and run slurm sync script as root user Refactor setting up network storage and run setup network storage as root May 8, 2024
mr0re1
mr0re1 previously approved these changes May 9, 2024
@mr0re1 mr0re1 assigned harshthakkar01 and unassigned mr0re1 May 9, 2024
@harshthakkar01 harshthakkar01 force-pushed the slurm-sync-service branch 3 times, most recently from 9f9aa2c to bcf2a0d Compare May 9, 2024 20:46
@harshthakkar01 harshthakkar01 requested a review from mr0re1 May 9, 2024 20:50
scripts/setup.py Outdated Show resolved Hide resolved
@nick-stroud nick-stroud assigned harshthakkar01 and unassigned mr0re1 May 10, 2024
@harshthakkar01 harshthakkar01 force-pushed the slurm-sync-service branch 6 times, most recently from 2cfef6f to 6bede70 Compare May 15, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants