Skip to content

chore(deps): update torch to 2.4.0 #13324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(deps): update torch to 2.4.0 #13324

wants to merge 1 commit into from

Conversation

glasnt
Copy link
Contributor

@glasnt glasnt commented Apr 28, 2025

Description

Replaces #13308, #13309

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

  • Please merge this PR for me once it is approved

@glasnt glasnt requested review from a team as code owners April 28, 2025 04:14
@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: people-and-planet-ai labels Apr 28, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @glasnt, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request updates the PyTorch dependency to version 2.4.0 in the weather-forecasting project. Specifically, it modifies the container_uri in the training notebook (3-training.ipynb) and the torch dependency version in the pyproject.toml file within the serving directory.

Highlights

  • Dependency Update: The primary focus is to upgrade the PyTorch version used in the weather forecasting project to 2.4.0.
  • Container URI: The container URI in the training notebook has been updated to reflect the new PyTorch version.
  • pyproject.toml: The torch dependency version in pyproject.toml has been updated to 2.4.0 to ensure consistency.

Changelog

  • people-and-planet-ai/weather-forecasting/notebooks/3-training.ipynb
    • Updated the container_uri to use pytorch-gpu.2-4.py310:latest to align with PyTorch 2.4.0 (line 1384).
  • people-and-planet-ai/weather-forecasting/serving/weather-model/pyproject.toml
    • Updated the torch dependency version to 2.4.0 (line 21).
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.


A tensor's journey,
From two-point-two to two-four,
Models learn anew.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request updates the pytorch version to 2.4.0 in the weather-forecasting project. This involves changes to the container URI in the training notebook and the torch dependency in the pyproject.toml file. The changes seem straightforward and necessary for keeping the project up-to-date with the latest pytorch version.

Merge Readiness

The pull request appears to be a straightforward dependency update. Since the changes are minimal and directly related to updating the pytorch version, it seems reasonable to merge once the checks pass. However, it's important to ensure that the updated pytorch version doesn't introduce any compatibility issues with the existing codebase. I am unable to approve the pull request, and users should have others review and approve this code before merging.

@glasnt glasnt changed the title chore(deps): update pytorch to 2.4.0 chore(deps): update torcg to 2.4.0 Apr 28, 2025
@glasnt glasnt changed the title chore(deps): update torcg to 2.4.0 chore(deps): update torch to 2.4.0 Apr 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: people-and-planet-ai samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants