chore(ci): migrate dataproc to new testing

[glasnt]

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

• I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
• Tests pass: npm test (see Testing)
• Lint pass: npm run lint (see Style)
• These samples need a new API enabled in testing projects to pass (let us know which ones)
• These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
• This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
• This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
• This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
• This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
• Please merge this PR for me once it is approved

[gemini-code-assist]

Hello @glasnt, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request migrates the Dataproc testing configuration to a new setup. This involves removing 'dataproc' from the nodejs.jsonc configuration file and adding it to nodejs-dev.jsonc. Additionally, the pull request updates the system tests for Dataproc by changing the environment variable used for the project ID from GCLOUD_PROJECT to PROJECT_ID in several test files.

Highlights

• Configuration Change: The PR moves 'dataproc' from the standard testing configuration to the development testing configuration.
• Environment Variable Update: The PR updates the environment variable used for the project ID in Dataproc system tests from GCLOUD_PROJECT to PROJECT_ID.

Changelog

Click here to see the changelog

• .github/config/nodejs-dev.jsonc
  • Added 'dataproc' to the list of services to be tested in the development environment.
• .github/config/nodejs.jsonc
  • Removed 'dataproc' from the list of services to be tested in the standard environment.
• dataproc/system-test/createCluster.test.js
  • Replaced process.env.GCLOUD_PROJECT with process.env.PROJECT_ID to retrieve the project ID.
• dataproc/system-test/instantiateInlineWorkflowTemplate.test.js
  • Replaced process.env.GCLOUD_PROJECT with process.env.PROJECT_ID to retrieve the project ID.
• dataproc/system-test/quickstart.test.js
  • Replaced process.env.GCLOUD_PROJECT with process.env.PROJECT_ID to retrieve the project ID.
• dataproc/system-test/submitJob.test.js
  • Replaced process.env.GCLOUD_PROJECT with process.env.PROJECT_ID to retrieve the project ID.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

---

A project ID's key,
From GCLOUD to PROJECT we flee,
Tests now aligned,
Success we find,
Dataproc runs smoothly, you see.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request migrates Dataproc testing to a new configuration. The changes involve updating configuration files and modifying test files to use a new environment variable. Overall, the changes seem straightforward and necessary for the new testing setup.

Summary of Findings

• Environment Variable Consistency: The change from GCLOUD_PROJECT to PROJECT_ID seems consistent across the Dataproc test files, which is good. However, it's important to ensure that this environment variable is correctly set in the testing environment.
• Configuration File Updates: The addition of dataproc to nodejs-dev.jsonc and removal from nodejs.jsonc suggests a change in the testing environment. It's important to verify that this change aligns with the intended testing strategy.

Merge Readiness

The changes appear to be correct and necessary for the new testing setup. However, it's crucial to ensure that the PROJECT_ID environment variable is correctly configured in the testing environment and that the configuration file updates align with the intended testing strategy. I am unable to approve this pull request, and recommend that others review and approve this code before merging.