Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle cloud.google.com/gke-dpv2-unified-cni node label #402

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

jingyuanliang
Copy link
Member

Skip CNI config file writing when the node label is set to true and Cilium CNI is being used (to be handed over to anetd; include "natural" DPv2 and migrated nodes during DPv2 migration).

/assign @sugangli @pravk03 @sypakine

Skip CNI config file writing when the node label is set to true and
Cilium CNI is being used (to be handed over to anetd; include "natural"
DPv2 and migrated nodes during DPv2 migration).
Copy link
Contributor

@jingyuanliang: GitHub didn't allow me to assign the following users: sugangli.

Note that only GoogleCloudPlatform members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

Skip CNI config file writing when the node label is set to true and Cilium CNI is being used (to be handed over to anetd; include "natural" DPv2 and migrated nodes during DPv2 migration).

/assign @sugangli @pravk03 @sypakine

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@google-oss-prow google-oss-prow bot added the lgtm label Jan 27, 2025
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jingyuanliang, pravk03

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit a0772de into GoogleCloudPlatform:master Jan 27, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants