Fix install-cni v2 template test cases broken by #297 #299
Conversation
|
@jingyuanliang: GitHub didn't allow me to assign the following users: marqc. Note that only GoogleCloudPlatform members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/assign @aojea |
| # shellcheck disable=SC2317 | ||
| function sleep() { | ||
| echo "[MOCK called] sleep $*" | ||
| echo "[MOCK] this test expects a delay during fast start." |
There was a problem hiding this comment.
how did the test passed before then?
There was a problem hiding this comment.
I suspect they just took much longer to pass, as it was actually sleeping/waiting for 60seconds.
This mock function does not verify anything.
There was a problem hiding this comment.
Ah. You're right. It should have failed on https://github.com/GoogleCloudPlatform/netd/blob/master/scripts/test-install-cni.sh#L48
There was a problem hiding this comment.
@aojea I see now. There were 2 PRs merged and each of them was working at the time they were sent and verified.
#269 and #297
So only after they were merged together into the master, the tests started failing. So probably we should have rebase #269 before merging on top of the master branch as this PR was waiting a few weeks before getting merged. The test logic works ok.
There was a problem hiding this comment.
IIRC github actions does not rebase, so it test against the state of the repo that was at that point
|
@marqc: changing LGTM is restricted to collaborators In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jingyuanliang, marqc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jingyuanliang
merged commit 171c993
into
GoogleCloudPlatform:master
/assign @marqc