-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testing framework for install-cni template processing #263
Testing framework for install-cni template processing #263
Conversation
This is impressive, let´s get a run on CI |
@jingyuanliang why are the githb actions not running? |
Add those new shell scripts to the target of shellcheck? |
those are tests, should we shelcheck the tests? you are the experts here, it looks good to me but I´m very lazy with bash so you should review @jingyuanliang |
Hmm I just had some nitpicks and wanted shellcheck to say it for me. |
Okay I just tried it. shellcheck gives many useless findings. Don't bother to add it then. |
b111771
to
b2133ab
Compare
I decided to add it to shellcheck. Even if findings are not important or false-positive, having the check in pipeline can prevent us from introducing bugs later on. I also want to add a readme file with documentation on the testing framework (how it works, how to use it). I will update the PR soon. |
b2133ab
to
8f53f2e
Compare
@jingyuanliang please take a look, it's ready for review now |
I can think of several other test cases, but we can start with the current ones. |
fe75234
to
763be1f
Compare
Signed-off-by: Marek Chodor <[email protected]> Change-Id: Idcacbffec8b385e3f22ca8262f4450f0b9b27e52
763be1f
to
74ad02e
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jingyuanliang, marqc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
0423153
into
GoogleCloudPlatform:master
Adds tests to verify cni_spec generation by install-cni.sh script