Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multi-host gpu tests to PyTorch/XLA #1011

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

vanbasten23
Copy link
Collaborator

Description

Please include a summary of relevant context/issue and your changes.

Tests

Please describe the tests that you ran on TPUs to verify changes.

Instruction and/or command lines to reproduce your tests: ...

List links for your tests (use go/shortn-gen for any internal link): ...

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run one-shot tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed.

],
},
},
subdomain: 'headless-svc-$(JOB_NAME)', # xw32: need to verify.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @will-cromar , currently when I run the test it fails with error The Job "pt-nightly-resnet50-mp-func-v100-x4-699rm" is invalid: spec.template.spec.subdomain: Invalid value: "headless-svc-$(JOB_NAME)": a lowercase RFC 1123 label must consist of lower case alphanumeric characters or '-', and must start and end with an alphanumeric character (e.g. 'my-name', or '123-abc', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?').
The subdomain name (headless-svc-$(JOB_NAME)) is the kubernetes service name. Do you know the correct way to make it depends on the job name?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant