Update Instance.yaml delete_url for Looker #11950

efeelaiho · 2024-10-08T23:28:03Z

Fixes hashicorp/terraform-provider-google#19467

Release Note Template for Downstream PRs (will be copied)

looker: fixed nested resource bug preventing deletion

github-actions · 2024-10-08T23:28:43Z

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

modular-magician · 2024-10-08T23:40:46Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))
google-beta provider: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

modular-magician · 2024-10-08T23:43:48Z

Tests analytics

Total tests: 7
Passed tests: 0
Skipped tests: 0
Affected tests: 7

Click here to see the affected service packages

looker

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccLookerInstance_lookerInstanceBasicExample

TestAccLookerInstance_lookerInstanceCustomDomainExample

TestAccLookerInstance_lookerInstanceEnterpriseFullTestExample

TestAccLookerInstance_lookerInstanceFipsExample

TestAccLookerInstance_lookerInstanceFullExample

TestAccLookerInstance_lookerInstancePscExample

TestAccLookerInstance_update

Get to know how VCR tests work

modular-magician · 2024-10-09T01:49:04Z

🟢 Tests passed during RECORDING mode:
TestAccLookerInstance_lookerInstanceBasicExample[Debug log]
TestAccLookerInstance_lookerInstanceCustomDomainExample[Debug log]
TestAccLookerInstance_lookerInstanceEnterpriseFullTestExample[Debug log]
TestAccLookerInstance_lookerInstanceFipsExample[Debug log]
TestAccLookerInstance_lookerInstancePscExample[Debug log]
TestAccLookerInstance_update[Debug log]
🔴 Tests failed when rerunning REPLAYING mode:
TestAccLookerInstance_lookerInstanceBasicExample[Error message] [Debug log]
TestAccLookerInstance_lookerInstanceEnterpriseFullTestExample[Error message] [Debug log]
TestAccLookerInstance_lookerInstanceFipsExample[Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccLookerInstance_lookerInstanceFullExample[Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

shuyama1

We'll likely need to hide this change behind a flag as changing resource default deletion behavior is a breaking change according https://googlecloudplatform.github.io/magic-modules/develop/breaking-changes/breaking-changes/#resource-level-breaking-changes and can't be made in a minor release. A similar example change: #6474

modular-magician · 2024-10-10T22:48:44Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 24 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 2 files changed, 24 insertions(+), 1 deletion(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_looker_instance (8 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_looker_instance" "primary" {
  force_delete = # value needed
}

modular-magician · 2024-10-10T22:51:04Z

Tests analytics

Total tests: 2
Passed tests: 0
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

looker

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccLookerInstance_lookerInstanceBasicExample

TestAccLookerInstance_lookerInstanceFipsExample

Get to know how VCR tests work

modular-magician · 2024-10-10T23:32:36Z

🔴 Several tests got terminated during RECORDING mode.
🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2024-10-11T04:46:38Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 23 insertions(+))
google-beta provider: Diff ( 2 files changed, 23 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_looker_instance (8 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_looker_instance" "primary" {
  force_delete = # value needed
}

modular-magician · 2024-10-11T04:48:44Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 23 insertions(+))
google-beta provider: Diff ( 2 files changed, 23 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_looker_instance (8 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_looker_instance" "primary" {
  force_delete = # value needed
}

modular-magician · 2024-10-11T04:49:08Z

Tests analytics

Total tests: 2
Passed tests: 0
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

looker

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccLookerInstance_lookerInstanceBasicExample

TestAccLookerInstance_lookerInstanceFipsExample

Get to know how VCR tests work

modular-magician · 2024-10-11T04:51:08Z

Tests analytics

Total tests: 2
Passed tests: 0
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

looker

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccLookerInstance_lookerInstanceBasicExample

TestAccLookerInstance_lookerInstanceFipsExample

Get to know how VCR tests work

modular-magician · 2024-10-11T05:04:06Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 27 insertions(+))
google-beta provider: Diff ( 2 files changed, 27 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_looker_instance (8 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_looker_instance" "primary" {
  force_delete = # value needed
}

modular-magician · 2024-10-11T05:06:38Z

Tests analytics

Total tests: 2
Passed tests: 0
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

looker

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccLookerInstance_lookerInstanceBasicExample

TestAccLookerInstance_lookerInstanceFipsExample

Get to know how VCR tests work

modular-magician · 2024-10-11T06:19:38Z

🔴 Tests failed during RECORDING mode:
TestAccLookerInstance_lookerInstanceBasicExample[Error message] [Debug log]

🔴 Several tests got terminated during RECORDING mode.
🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2024-10-11T06:21:38Z

🔴 Tests failed during RECORDING mode:
TestAccLookerInstance_lookerInstanceBasicExample[Error message] [Debug log]
TestAccLookerInstance_lookerInstanceFipsExample[Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2024-10-11T06:37:10Z

🔴 Tests failed during RECORDING mode:
TestAccLookerInstance_lookerInstanceBasicExample[Error message] [Debug log]
TestAccLookerInstance_lookerInstanceFipsExample[Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2024-10-11T14:26:30Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 27 insertions(+))
google-beta provider: Diff ( 2 files changed, 27 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_looker_instance (8 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_looker_instance" "primary" {
  force_delete = # value needed
}

modular-magician · 2024-10-11T14:29:01Z

Tests analytics

Total tests: 2
Passed tests: 0
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

looker

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccLookerInstance_lookerInstanceBasicExample

TestAccLookerInstance_lookerInstanceFipsExample

Get to know how VCR tests work

modular-magician · 2024-10-11T15:36:14Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 27 insertions(+))
google-beta provider: Diff ( 2 files changed, 27 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_looker_instance (8 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_looker_instance" "primary" {
  force_delete = # value needed
}

modular-magician · 2024-10-11T15:39:32Z

Tests analytics

Total tests: 2
Passed tests: 0
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

looker

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccLookerInstance_lookerInstanceBasicExample

TestAccLookerInstance_lookerInstanceFipsExample

Get to know how VCR tests work

modular-magician · 2024-10-11T15:59:32Z

🔴 Tests failed during RECORDING mode:
TestAccLookerInstance_lookerInstanceBasicExample[Error message] [Debug log]
TestAccLookerInstance_lookerInstanceFipsExample[Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2024-10-11T17:10:02Z

🔴 Tests failed during RECORDING mode:
TestAccLookerInstance_lookerInstanceBasicExample[Error message] [Debug log]
TestAccLookerInstance_lookerInstanceFipsExample[Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

…c-modules into looker_delete_url

modular-magician · 2024-10-12T04:15:45Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 29 insertions(+))
google-beta provider: Diff ( 2 files changed, 29 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_looker_instance (8 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_looker_instance" "primary" {
  deletion_policy = # value needed
}

modular-magician · 2024-10-12T04:17:17Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 29 insertions(+))
google-beta provider: Diff ( 2 files changed, 29 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_looker_instance (8 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_looker_instance" "primary" {
  deletion_policy = # value needed
}

modular-magician · 2024-10-12T04:18:24Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 29 insertions(+))
google-beta provider: Diff ( 2 files changed, 29 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_looker_instance (8 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_looker_instance" "primary" {
  deletion_policy = # value needed
}

modular-magician · 2024-10-12T04:18:25Z

Tests analytics

Total tests: 7
Passed tests: 1
Skipped tests: 0
Affected tests: 6

Click here to see the affected service packages

looker

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccLookerInstance_lookerInstanceBasicExample

TestAccLookerInstance_lookerInstanceCustomDomainExample

TestAccLookerInstance_lookerInstanceEnterpriseFullTestExample

TestAccLookerInstance_lookerInstanceFipsExample

TestAccLookerInstance_lookerInstancePscExample

TestAccLookerInstance_update

Get to know how VCR tests work

modular-magician · 2024-10-12T04:20:26Z

Tests analytics

Total tests: 7
Passed tests: 1
Skipped tests: 0
Affected tests: 6

Click here to see the affected service packages

looker

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccLookerInstance_lookerInstanceBasicExample

TestAccLookerInstance_lookerInstanceCustomDomainExample

TestAccLookerInstance_lookerInstanceEnterpriseFullTestExample

TestAccLookerInstance_lookerInstanceFipsExample

TestAccLookerInstance_lookerInstancePscExample

TestAccLookerInstance_update

Get to know how VCR tests work

modular-magician · 2024-10-12T04:21:34Z

Tests analytics

Total tests: 7
Passed tests: 1
Skipped tests: 0
Affected tests: 6

Click here to see the affected service packages

looker

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccLookerInstance_lookerInstanceBasicExample

TestAccLookerInstance_lookerInstanceCustomDomainExample

TestAccLookerInstance_lookerInstanceEnterpriseFullTestExample

TestAccLookerInstance_lookerInstanceFipsExample

TestAccLookerInstance_lookerInstancePscExample

TestAccLookerInstance_update

Get to know how VCR tests work

modular-magician · 2024-10-12T05:20:28Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 29 insertions(+))
google-beta provider: Diff ( 2 files changed, 29 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_looker_instance (8 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_looker_instance" "primary" {
  deletion_policy = # value needed
}

modular-magician · 2024-10-12T05:23:06Z

Tests analytics

Total tests: 7
Passed tests: 1
Skipped tests: 0
Affected tests: 6

Click here to see the affected service packages

looker

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccLookerInstance_lookerInstanceBasicExample

TestAccLookerInstance_lookerInstanceCustomDomainExample

TestAccLookerInstance_lookerInstanceEnterpriseFullTestExample

TestAccLookerInstance_lookerInstanceFipsExample

TestAccLookerInstance_lookerInstancePscExample

TestAccLookerInstance_update

Get to know how VCR tests work

modular-magician · 2024-10-12T05:49:06Z

🔴 Tests failed during RECORDING mode:
TestAccLookerInstance_lookerInstanceBasicExample[Error message] [Debug log]
TestAccLookerInstance_lookerInstanceCustomDomainExample[Error message] [Debug log]
TestAccLookerInstance_lookerInstanceEnterpriseFullTestExample[Error message] [Debug log]
TestAccLookerInstance_lookerInstanceFipsExample[Error message] [Debug log]
TestAccLookerInstance_lookerInstancePscExample[Error message] [Debug log]
TestAccLookerInstance_update[Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2024-10-12T05:51:11Z

🔴 Tests failed during RECORDING mode:
TestAccLookerInstance_lookerInstanceBasicExample[Error message] [Debug log]
TestAccLookerInstance_lookerInstanceCustomDomainExample[Error message] [Debug log]
TestAccLookerInstance_lookerInstanceEnterpriseFullTestExample[Error message] [Debug log]
TestAccLookerInstance_lookerInstanceFipsExample[Error message] [Debug log]
TestAccLookerInstance_lookerInstancePscExample[Error message] [Debug log]
TestAccLookerInstance_update[Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2024-10-12T05:52:19Z

🔴 Tests failed during RECORDING mode:
TestAccLookerInstance_lookerInstanceBasicExample[Error message] [Debug log]
TestAccLookerInstance_lookerInstanceCustomDomainExample[Error message] [Debug log]
TestAccLookerInstance_lookerInstanceEnterpriseFullTestExample[Error message] [Debug log]
TestAccLookerInstance_lookerInstanceFipsExample[Error message] [Debug log]
TestAccLookerInstance_lookerInstancePscExample[Error message] [Debug log]
TestAccLookerInstance_update[Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2024-10-12T06:53:48Z

🔴 Tests failed during RECORDING mode:
TestAccLookerInstance_lookerInstanceBasicExample[Error message] [Debug log]
TestAccLookerInstance_lookerInstanceCustomDomainExample[Error message] [Debug log]
TestAccLookerInstance_lookerInstanceEnterpriseFullTestExample[Error message] [Debug log]
TestAccLookerInstance_lookerInstanceFipsExample[Error message] [Debug log]
TestAccLookerInstance_lookerInstancePscExample[Error message] [Debug log]
TestAccLookerInstance_update[Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Update Instance.yaml delete_url for looker

dd96f63

github-actions bot requested a review from shuyama1 October 8, 2024 23:28

modular-magician added the service/looker-core label Oct 8, 2024

shuyama1 reviewed Oct 10, 2024

View reviewed changes

Update Instance.yaml with force_delete virtual field

eb29ebc

github-actions bot requested a review from shuyama1 October 10, 2024 22:39

efeelaiho added 5 commits October 11, 2024 00:36

Create looker_instance.go.tmpl

a157eb5

Update Instance.yaml

8b0b822

Update Instance.yaml

4676fd6

Update Instance.yaml

2eb520e

Update looker_instance.go.tmpl

a4995ca

Update Instance.yaml

9b70a39

Update looker_instance.go.tmpl

fe56469

Update looker_instance.go.tmpl

cf7c78a

efeelaiho and others added 4 commits October 12, 2024 03:58

Update Instance.yaml and looker_instance.go.tmpl for a passing delete

be6e8a1

Merge branch 'looker_delete_url' of https://github.com/efeelaiho/magi…

e38cd93

…c-modules into looker_delete_url

Merge branch 'GoogleCloudPlatform:main' into looker_delete_url

1ef4463

Update looker_instance.go.tmpl

fbb27fb

Remove trailing space

86def9b

Update Instance.yaml delete_url for Looker #11950

Are you sure you want to change the base?

Update Instance.yaml delete_url for Looker #11950

Conversation

efeelaiho commented Oct 8, 2024

github-actions bot commented Oct 8, 2024

modular-magician commented Oct 8, 2024

Diff report

modular-magician commented Oct 8, 2024

Tests analytics

Action taken

modular-magician commented Oct 9, 2024

shuyama1 left a comment

Choose a reason for hiding this comment

modular-magician commented Oct 10, 2024

Diff report

Missing test report

modular-magician commented Oct 10, 2024

Tests analytics

Action taken

modular-magician commented Oct 10, 2024

modular-magician commented Oct 11, 2024

Diff report

Missing test report

modular-magician commented Oct 11, 2024

Diff report

Missing test report

modular-magician commented Oct 11, 2024

Tests analytics

Action taken

modular-magician commented Oct 11, 2024

Tests analytics

Action taken

modular-magician commented Oct 11, 2024

Diff report

Missing test report

modular-magician commented Oct 11, 2024

Tests analytics

Action taken

modular-magician commented Oct 11, 2024

modular-magician commented Oct 11, 2024

modular-magician commented Oct 11, 2024

modular-magician commented Oct 11, 2024

Diff report

Missing test report

modular-magician commented Oct 11, 2024

Tests analytics

Action taken

modular-magician commented Oct 11, 2024

Diff report

Missing test report

modular-magician commented Oct 11, 2024

Tests analytics

Action taken

modular-magician commented Oct 11, 2024

modular-magician commented Oct 11, 2024

modular-magician commented Oct 12, 2024

Diff report

Missing test report

modular-magician commented Oct 12, 2024

Diff report

Missing test report

modular-magician commented Oct 12, 2024

Diff report

Missing test report

modular-magician commented Oct 12, 2024

Tests analytics

Action taken

modular-magician commented Oct 12, 2024

Tests analytics

Action taken

modular-magician commented Oct 12, 2024

Tests analytics

Action taken

modular-magician commented Oct 12, 2024

Diff report

Missing test report

modular-magician commented Oct 12, 2024

Tests analytics

Action taken