Skip to content

Commit

Permalink
Stronger callout for tests that need manual runs (#11974)
Browse files Browse the repository at this point in the history
  • Loading branch information
melinath authored Oct 12, 2024
1 parent 9dc28c8 commit 91cb073
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
6 changes: 3 additions & 3 deletions .ci/magician/cmd/templates/vcr/non_exercised_tests.tmpl
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
{{- if or (gt (len .NotRunBetaTests) 0) (gt (len .NotRunGATests) 0) -}}
{{- if or (gt (len .NotRunBetaTests) 0) (gt (len .NotRunGATests) 0)}}
#### Non-exercised tests

{{if gt (len .NotRunBetaTests) 0 -}}
Tests were added that are skipped in VCR:
{{color "red" "Tests were added that are skipped in VCR:"}}
{{range .NotRunBetaTests}}{{. | printf "- %s\n"}}{{end}}
{{end}}

{{if gt (len .NotRunGATests) 0 -}}
Tests were added that are GA-only additions and require manual runs:
{{color "red" "Tests were added that are GA-only additions and require manual runs:"}}
{{range .NotRunGATests}}{{. | printf "- %s\n"}}{{end}}
{{end}}
{{end}}
8 changes: 4 additions & 4 deletions .ci/magician/cmd/test_terraform_vcr_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -356,7 +356,7 @@ func TestNonExercisedTestsComment(t *testing.T) {
[]string{
"#### Non-exercised tests",
"",
"Tests were added that are skipped in VCR:",
color("red", "Tests were added that are skipped in VCR:"),
"- beta-1",
"- beta-2",
},
Expand All @@ -374,7 +374,7 @@ func TestNonExercisedTestsComment(t *testing.T) {
"",
"",
"",
"Tests were added that are GA-only additions and require manual runs:",
color("red", "Tests were added that are GA-only additions and require manual runs:"),
"- ga-1",
"- ga-2",
},
Expand All @@ -391,13 +391,13 @@ func TestNonExercisedTestsComment(t *testing.T) {
[]string{
"#### Non-exercised tests",
"",
"Tests were added that are skipped in VCR:",
color("red", "Tests were added that are skipped in VCR:"),
"- beta-1",
"- beta-2",
"",
"",
"",
"Tests were added that are GA-only additions and require manual runs:",
color("red", "Tests were added that are GA-only additions and require manual runs:"),
"- ga-1",
"- ga-2",
},
Expand Down

0 comments on commit 91cb073

Please sign in to comment.