Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: AbortController to signal request timeouts #600

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

matthewrobertson
Copy link
Member

This commit adds a nodejs AbortController to the HTTP request object that is used to signal cancellation for a function execution in the event of a timeout or client disconnect.

@matthewrobertson matthewrobertson changed the title add an abort controller to signal request timeouts feat: AbortController to signal request timeouts Apr 25, 2024
Copy link
Contributor

@HKWinterhalter HKWinterhalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for figuring this out

src/middleware/timeout.ts Show resolved Hide resolved
src/options.ts Outdated Show resolved Hide resolved
src/options.ts Show resolved Hide resolved
src/main.ts Show resolved Hide resolved
src/server.ts Show resolved Hide resolved
@matthewrobertson matthewrobertson force-pushed the zombie-timeouts branch 5 times, most recently from c937173 to 8d63104 Compare April 26, 2024 20:25
This commit adds a nodejs AbortController to the HTTP request object that is
used to signal cancellation for a function execution in the event of a timeout
or client disconnect.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants