-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add integration test for MySQL2Spanner notebook #1001
Open
NiloFreitas
wants to merge
15
commits into
main
Choose a base branch
from
860-integration-tests-notebook
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NiloFreitas
changed the title
Add integration test for MySQL2Spanner notebook
feat: Add integration test for MySQL2Spanner notebook
Oct 21, 2024
NiloFreitas
force-pushed
the
860-integration-tests-notebook
branch
from
October 24, 2024 13:29
3aecf59
to
8152f31
Compare
shashank-google
requested review from
rajc242
and removed request for
shashank-google
October 25, 2024 16:24
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add integration test for the mysql2spanner notebook.
The integration test is run by leveraging the MySqlToSpanner_parameterize_script, which allows running the notebook as a python script with the parameters specified by sys args.
Closes #860