Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: BigQuery_To_JDBC #1000

Merged
merged 21 commits into from
Oct 26, 2024
Merged

feat: BigQuery_To_JDBC #1000

merged 21 commits into from
Oct 26, 2024

Conversation

hhasija
Copy link
Collaborator

@hhasija hhasija commented Oct 21, 2024

No description provided.

@hhasija hhasija changed the title feat: BigQuery_To feat: BigQuery_To_JDBC Oct 21, 2024
rajc242
rajc242 requested changes Oct 23, 2024
View reviewed changes
Copy link
Collaborator

@rajc242 rajc242 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please provide validation through validation class as JDBCToGCSConfig

We are trying to standardize validation through config class for new templates.

@rajc242 rajc242 added enhancement New feature or request java labels Oct 23, 2024
@hhasija hhasija requested a review from rajc242 October 23, 2024 10:20
@hhasija hhasija requested a review from rajc242 October 24, 2024 12:14
rajc242
rajc242 requested changes Oct 24, 2024
View reviewed changes
Copy link
Collaborator

@rajc242 rajc242 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please could you add one execution in Jenkins file for validation.

@hhasija
Copy link
Collaborator Author

hhasija commented Oct 25, 2024

Could you please provide validation through validation class as JDBCToGCSConfig

We are trying to standardize validation through config class for new templates.

Changes Done. Please review it once.

@hhasija
Copy link
Collaborator Author

hhasija commented Oct 25, 2024

Please could you add one execution in Jenkins file for validation.

Changes done. Please do review it once.

@hhasija hhasija requested a review from rajc242 October 25, 2024 08:50
rajc242
rajc242 approved these changes Oct 26, 2024
View reviewed changes
Copy link
Collaborator

@rajc242 rajc242 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rajc242 rajc242 merged commit f602c05 into main Oct 26, 2024
9 checks passed
@rajc242 rajc242 deleted the BigQuery-To-JDBC branch October 26, 2024 17:55
@release-please release-please bot mentioned this pull request Oct 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajc242 rajc242 rajc242 approved these changes

@shashank-google shashank-google Awaiting requested review from shashank-google

@surjits254 surjits254 Awaiting requested review from surjits254

Assignees

@hhasija hhasija

Labels
enhancement New feature or request java
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hhasija @rajc242