Skip to content

Improve Slurm tests #4201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Improve Slurm tests #4201

wants to merge 1 commit into from

Conversation

mr0re1
Copy link
Collaborator

@mr0re1 mr0re1 commented May 27, 2025 •
edited
Loading

  • Don't override pre-existing SSH-key;
  • Don't override "normal" key file google_compute_engine, instead use dedicated slurm_tests;
  • Add more logging;
  • Use shared tunnels and ssh connections;
  • Log out output of commands;
  • Don't use time.sleep, instead inspect outputs of commands to decide readiness (tunnel setup);
  • Inspect /slurm/scripts/setup.log to decide on readiness.

@mr0re1 mr0re1 requested review from samskillman and a team as code owners May 27, 2025 19:11
@mr0re1 mr0re1 added the release-chore To not include into release notes label May 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samskillman samskillman Awaiting requested review from samskillman samskillman is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
release-chore To not include into release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mr0re1