Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add firewall to allow tcp traffic for parallelstore #3262

Merged
merged 3 commits into from
Nov 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions community/modules/network/private-service-access/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@ No modules.

| Name | Description |
|------|-------------|
| <a name="output_cidr_range"></a> [cidr\_range](#output\_cidr\_range) | CIDR range of the created google\_compute\_global\_address |
| <a name="output_connect_mode"></a> [connect\_mode](#output\_connect\_mode) | Services that use Private Service Access typically specify connect\_mode<br/>"PRIVATE\_SERVICE\_ACCESS". This output value sets connect\_mode and additionally<br/>blocks terraform actions until the VPC connection has been created. |
| <a name="output_private_vpc_connection_peering"></a> [private\_vpc\_connection\_peering](#output\_private\_vpc\_connection\_peering) | The name of the VPC Network peering connection that was created by the service provider. |
| <a name="output_reserved_ip_range"></a> [reserved\_ip\_range](#output\_reserved\_ip\_range) | Named IP range to be used by services connected with Private Service Access. |
Expand Down
5 changes: 5 additions & 0 deletions community/modules/network/private-service-access/outputs.tf
Original file line number Diff line number Diff line change
Expand Up @@ -36,3 +36,8 @@ output "reserved_ip_range" {
description = "Named IP range to be used by services connected with Private Service Access."
value = google_compute_global_address.private_ip_alloc.name
}

output "cidr_range" {
description = "CIDR range of the created google_compute_global_address"
value = "${google_compute_global_address.private_ip_alloc.address}/${google_compute_global_address.private_ip_alloc.prefix_length}"
}
13 changes: 13 additions & 0 deletions examples/gke-storage-parallelstore.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,19 @@ deployment_groups:

- group: primary
modules:
# allow parallelstore connection
- id: parallelstore_firewall_rule
source: modules/network/firewall-rules
use: [network]
settings:
ingress_rules:
- name: $(vars.deployment_name)-allow-parallelstore-traffic
description: Allow parallelstore traffic
source_ranges:
- $(private_service_access.cidr_range)
allow:
- protocol: tcp

- id: gke_cluster
source: modules/scheduler/gke-cluster
use: [network]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@

---
tags:
- m.firewall-rules
- m.gke-cluster
- m.gke-job-template
- m.gke-node-pool
Expand Down
Loading