Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Access to GCE Public IPs for the GKE Integration Test Clusters #3249

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions examples/gke-a3-highgpu.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ vars:
# The following line must be updated for this example to work.
authorized_cidr: <your-ip-address>/32

gcp_public_cidrs_access_enabled: false

deployment_groups:
- group: primary
modules:
Expand Down Expand Up @@ -67,6 +69,7 @@ deployment_groups:
use: [network1, gpunets, gke_service_account]
settings:
enable_private_endpoint: false # Allows for access from authorized public IPs
gcp_public_cidrs_access_enabled: $(vars.gcp_public_cidrs_access_enabled)
master_authorized_networks:
- cidr_block: $(vars.authorized_cidr) # Allows your machine run kubectl command. It's required for the multi-network setup.
display_name: "kubectl-access-network"
Expand Down
3 changes: 3 additions & 0 deletions examples/gke-a3-megagpu.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ vars:
# The following line must be updated for this example to work.
authorized_cidr: <your-ip-address>/32

gcp_public_cidrs_access_enabled: false

deployment_groups:
- group: primary
modules:
Expand Down Expand Up @@ -67,6 +69,7 @@ deployment_groups:
use: [network1, gpunets, gke_service_account]
settings:
enable_private_endpoint: false # Allows for access from authorized public IPs
gcp_public_cidrs_access_enabled: $(vars.gcp_public_cidrs_access_enabled)
master_authorized_networks:
- cidr_block: $(vars.authorized_cidr) # Allows your machine run kubectl command. It's required for the multi-network setup.
display_name: "kubectl-access-network"
Expand Down
3 changes: 3 additions & 0 deletions examples/gke-storage-parallelstore.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ vars:
# The following line must be updated for this example to work.
authorized_cidr: <your-ip-address>/32

gcp_public_cidrs_access_enabled: false

deployment_groups:
- group: setup
modules:
Expand Down Expand Up @@ -52,6 +54,7 @@ deployment_groups:
enable_parallelstore_csi: true # enable Parallelstore for the cluster
configure_workload_identity_sa: true
enable_private_endpoint: false # Allows for access from authorized public IPs
gcp_public_cidrs_access_enabled: $(vars.gcp_public_cidrs_access_enabled)
master_authorized_networks:
- display_name: deployment-machine
cidr_block: $(vars.authorized_cidr)
Expand Down
2 changes: 2 additions & 0 deletions examples/hpc-gke.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ vars:
project_id: ## Set GCP Project ID Here ##
deployment_name: cluster-01
region: us-central1
gcp_public_cidrs_access_enabled: false

deployment_groups:
- group: primary
Expand Down Expand Up @@ -52,6 +53,7 @@ deployment_groups:
use: [network1, gke_service_account]
settings:
enable_private_endpoint: false # Allows for access from authorized public IPs
gcp_public_cidrs_access_enabled: $(vars.gcp_public_cidrs_access_enabled)
outputs: [instructions]

- id: compute_pool
Expand Down
3 changes: 3 additions & 0 deletions examples/ml-gke.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ vars:
# The following line must be updated for this example to work.
authorized_cidr: <your-ip-address>/32

gcp_public_cidrs_access_enabled: false

deployment_groups:
- group: primary
modules:
Expand Down Expand Up @@ -57,6 +59,7 @@ deployment_groups:
use: [network1, gke_service_account]
settings:
enable_private_endpoint: false # Allows for access from authorized public IPs
gcp_public_cidrs_access_enabled: $(vars.gcp_public_cidrs_access_enabled)
master_authorized_networks:
- display_name: deployment-machine
cidr_block: $(vars.authorized_cidr)
Expand Down
3 changes: 3 additions & 0 deletions examples/storage-gke.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ vars:
# The following line must be updated for this example to work.
authorized_cidr: <your-ip-address>/32

gcp_public_cidrs_access_enabled: false

deployment_groups:
- group: primary
modules:
Expand Down Expand Up @@ -58,6 +60,7 @@ deployment_groups:
enable_gcsfuse_csi: true
configure_workload_identity_sa: true # needed when using GCS
enable_private_endpoint: false # Allows for access from authorized public IPs
gcp_public_cidrs_access_enabled: $(vars.gcp_public_cidrs_access_enabled)
master_authorized_networks:
- display_name: deployment-machine
cidr_block: $(vars.authorized_cidr)
Expand Down
3 changes: 3 additions & 0 deletions tools/cloud-build/daily-tests/blueprints/ml-gke-e2e.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ vars:
# The following line must be updated for this example to work.
authorized_cidr: <your-ip-address>/32

gcp_public_cidrs_access_enabled: false

deployment_groups:
- group: primary
modules:
Expand Down Expand Up @@ -57,6 +59,7 @@ deployment_groups:
use: [network1, gke_service_account]
settings:
enable_private_endpoint: false # Allows for access from authorized public IPs
gcp_public_cidrs_access_enabled: $(vars.gcp_public_cidrs_access_enabled)
master_authorized_networks:
- display_name: deployment-machine
cidr_block: $(vars.authorized_cidr)
Expand Down
1 change: 1 addition & 0 deletions tools/cloud-build/daily-tests/tests/gke-a3-highgpu.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ cli_deployment_vars:
authorized_cidr: "{{ build_ip.stdout }}/32"
network_name: "{{ network }}"
local_ssd_count_nvme_block: 16
gcp_public_cidrs_access_enabled: true
custom_vars:
project: "{{ project }}"
post_deploy_tests:
Expand Down
1 change: 1 addition & 0 deletions tools/cloud-build/daily-tests/tests/gke-a3-megagpu.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ cli_deployment_vars:
authorized_cidr: "{{ build_ip.stdout }}/32"
network_name: "{{ network }}"
local_ssd_count_nvme_block: 16
gcp_public_cidrs_access_enabled: true
custom_vars:
project: "{{ project }}"
post_deploy_tests:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,3 +26,4 @@ custom_vars:
project: "{{ project }}"
cli_deployment_vars:
region: "{{ region }}"
gcp_public_cidrs_access_enabled: true
1 change: 1 addition & 0 deletions tools/cloud-build/daily-tests/tests/gke-storage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,3 +23,4 @@ post_deploy_tests: []
cli_deployment_vars:
network_name: "{{ network }}"
authorized_cidr: "{{ build_ip.stdout }}/32"
gcp_public_cidrs_access_enabled: true
2 changes: 2 additions & 0 deletions tools/cloud-build/daily-tests/tests/gke.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,6 @@ workspace: /workspace
blueprint_yaml: "{{ workspace }}/examples/hpc-gke.yaml"
network: "{{ deployment_name }}-net"
remote_node: "{{ deployment_name }}-0"
cli_deployment_vars:
gcp_public_cidrs_access_enabled: true
post_deploy_tests: []
1 change: 1 addition & 0 deletions tools/cloud-build/daily-tests/tests/ml-gke-e2e.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ network: "{{ deployment_name }}-net"
remote_node: "{{ deployment_name }}-0"
cli_deployment_vars:
region: "{{ region }}"
gcp_public_cidrs_access_enabled: true
custom_vars:
project: "{{ project }}"
post_deploy_tests:
Expand Down
1 change: 1 addition & 0 deletions tools/cloud-build/daily-tests/tests/ml-gke.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ network: "{{ deployment_name }}-net"
remote_node: "{{ deployment_name }}-0"
cli_deployment_vars:
region: "{{ region }}"
gcp_public_cidrs_access_enabled: true
custom_vars:
project: "{{ project }}"
post_deploy_tests:
Expand Down
Loading