add integration tests for kueue for A3 high #3236
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ighosh98
added
test-enhancement
Remove upper bound for best practices and impose correct lower bound https://github.com/hashicorp/terraform-provider-google-beta/releases/tag/v4.56.0
…oolkit" This reverts commit 5cb64ac.
The use of check blocks requires Terraform 1.5 and above.
The gke-node-pool module uses older "attribute" syntax for the GPU-related arguments that has been removed in the google Terraform plugin 6.x. This commit replaces attribute syntax with block syntax. The key to understanding this change is that a dynamic block iterating over a list is equivalent to null when the list is empty (no dynamic blocks are inserted). The gpu_sharing_config and gpu_driver_installation_config settings are not (and never were) list(object) in the Terraform plugin. They could only ever taken on length 0 or 1. These are therefore being converted to object format as they are in the API. https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/container_cluster#nested_guest_accelerator https://developer.hashicorp.com/terraform/language/attr-as-blocks
This commit fixes the documentation and examples to align with changes introduced in a9c2a69 to make gke-node-pool module compatible with TPG 6.x.
ighosh98
changed the title
ighosh98
changed the title
|
Changed to published as A3U integration tests will be directed at experimental branch. Aligned with @annuay-google |
ighosh98
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submission Checklist
NOTE: Community submissions can take up to 2 weeks to be reviewed.
Please take the following actions before submitting this pull request.