Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): [database-archival] Update dependency flask-appbuilder to v4.5.1 [SECURITY] #143

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

renovate-bot
Copy link
Contributor

@renovate-bot renovate-bot commented Jan 13, 2025

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
flask-appbuilder ==4.5.0 -> ==4.5.1 age adoption passing confidence

GitHub Vulnerability Alerts

CVE-2024-45314

Impact

Auth DB login form default cache directives allows browser to locally store sensitive data. This can be an issue on environments using shared computer resources.

Patches

Upgrade flask-appbuilder to version 4.5.1

Workarounds

If upgrading is not possible configure your web server to send the following HTTP headers for /login:
"Cache-Control": "no-store, no-cache, must-revalidate, max-age=0"
"Pragma": "no-cache"
"Expires": "0"


Release Notes

dpgaspar/flask-appbuilder (flask-appbuilder)

v4.5.1

Compare Source

  • feat: add no cache directive to login forms (#​2266) [Daniel Vaz Gaspar]
  • chore: bump cryptography to 42.0.4 (#​2238) [Daniel Vaz Gaspar]
  • docs: Fixing broken link (#​2252) [Chase Jones]
  • fix: rate limiter key function (#​2254) [Daniel Vaz Gaspar]
  • chore: bump dnspython to fix vulnerability (#​2255) [Daniel Vaz Gaspar]

Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

Copy link

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi team,

I'm currently reviewing this pull request and will provide my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly understand the changes:

This pull request, submitted by Renovate Bot, updates the flask-appbuilder dependency in the database-archival project from version 4.5.0 to 4.5.1. This is a security update addressing CVE-2024-45314, which involves a vulnerability in the default cache directives of the authentication database login form that could allow sensitive data to be stored locally in the browser.

Here's a breakdown of the changes:

  • Intent: Address a security vulnerability (CVE-2024-45314) in flask-appbuilder.
  • Changes: The requirements.txt file in the projects/database-archival directory has been modified to update flask-appbuilder to version 4.5.1. The specific change is updating the version number and associated hash in lines 579-581 of requirements.txt:
--- a/projects/database-archival/requirements.txt
+++ b/projects/database-archival/requirements.txt
@@ -576,9 +576,9 @@ flask==2.2.5 \
     #   flask-sqlalchemy
     #   flask-wtf
     #   functions-framework
-flask-appbuilder==4.5.0 \
-    --hash=sha256:0a8439fe9391d71cbbd64a149b5bb04c90cb4c344e4e3250316f59720b73579d \
-    --hash=sha256:f85866bd1b25d5edd5de793c102bb14ee1ccf7623983f92e9037430fed2a269b
+Flask-AppBuilder==4.5.1 \
+    --hash=sha256:4b61267d880299915951c6cd120856e107344cee8a11be832725c21f9bdc5f59 \
+    --hash=sha256:a53116ac26f276ac206fb549d5e23bcfb49612cccfd52da984af7951758e6eb0
     # via apache-airflow-providers-fab
 flask-babel==2.0.0 \
     --hash=sha256:e6820a052a8d344e178cdd36dd4bb8aea09b4bda3d5f9fa9f008df2c7f2f5468 \
  • Activity: The pull request was automatically generated by Renovate Bot.

Let me know if you have any questions.


A tiny verse, a coding plea,
Security first, you'll agree.
A simple fix, a patch applied,
Safe code flows, our fears subside.

Copy link

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request updates the flask-appbuilder dependency to version 4.5.1, which addresses a security vulnerability (CVE-2024-45314). The update is necessary and the PR is well-formatted with clear explanations of the change, impact, and release notes. The inclusion of SHA256 hashes is good practice. One small suggestion for improvement would be to add a test to verify the fix for CVE-2024-45314 if feasible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant