feat: adds processing logic for bpmetadata to use protobuf #1705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to make metadata schema definition language independent,
bpmetadata now processes metadata content using protobuf.
Known issues:
- BlueprintVariable.DefaultValue is changed from interface{} to string.
This can cause error messages while running bpmetadata on existing
blueprints. Solution: run bpmetadata with -f to force creation of
proto compliant metadata.
- Go docs will most likely have superfluous types and methods not
directly related to metadata. Solution: use protos as the source of
truth for metadata definition and specs.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
bharathkkb
reviewed
Jul 10, 2023
There was a problem hiding this comment.
Thanks @g-awmalik! Are there any benefits to checking in the generated files? I was thinking we could generate these at build time and add to gitignore?
apeabody
changed the title
bharathkkb
approved these changes
Jul 13, 2023
We can but i'll do that after this goes through because the CFT CLI Tests check will fail since it executes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to make metadata schema definition language independent, bpmetadata now processes metadata content using protobuf.
Known issues: