Add Windows support

pkg/netrc/netrc.go

@@ -20,8 +20,9 @@ import (
 	"io/ioutil"
 	"log"
 	"os"
-	"path"
+	"path/filepath"
 	"regexp"
+	"runtime"
 	"strings"
 
 	"github.com/GoogleCloudPlatform/artifact-registry-go-tools/pkg/auth"
@@ -43,6 +44,14 @@ password %s
 `, host, base64key)
 }
 
+func getNetrcFileName() string {
+	// return _netrc for Windows and .netrc for Unix
+	if runtime.GOOS == "windows" {
+		return "_netrc"
+	}
+	return ".netrc"
+}
+
 // Load loads the path and contents of the .netrc file into memory.
 func Load() (string, string, error) {
 	netrcPath := os.Getenv("NETRC")
@@ -54,15 +63,16 @@ func Load() (string, string, error) {
 		netrcPath = h
 	}
 
-	if !strings.HasSuffix(netrcPath, ".netrc") {
-		netrcPath = path.Join(netrcPath, ".netrc")
+	netrcFileName := getNetrcFileName()
+	if !strings.HasSuffix(netrcPath, netrcFileName) {
+		netrcPath = filepath.Join(netrcPath, netrcFileName)
 	}
 
-	if _, err := os.Stat(path.Dir(netrcPath)); err != nil {
+	if _, err := os.Stat(filepath.Dir(netrcPath)); err != nil {
 		if os.IsNotExist(err) {
-			return "", "", fmt.Errorf(".netrc directory does not exist: %w", err)
+			return "", "", fmt.Errorf("%s directory does not exist: %w", netrcFileName, err)
 		}
-		return "", "", fmt.Errorf("failed to load .netrc directory: %w", err)
+		return "", "", fmt.Errorf("failed to load %s directory: %w", netrcFileName, err)
 	}
 
 	data, err := ioutil.ReadFile(netrcPath)
@@ -71,7 +81,7 @@ func Load() (string, string, error) {
 		return netrcPath, "", nil
 	}
 	if err != nil {
-		return "", "", fmt.Errorf("cannot load .netrc file: %v", err)
+		return "", "", fmt.Errorf("cannot load %s file: %v", netrcFileName, err)
 	}
 	return netrcPath, string(data), nil
 }

pkg/netrc/netrc_test.go

@@ -4,7 +4,7 @@ import (
 	_ "embed"
 	"errors"
 	"os"
-	"path"
+	"path/filepath"
 	"testing"
 )
 
@@ -41,7 +41,7 @@ password <oauth2accesstoken>
 			jsonKeyPath: "testdata/key.json",
 			wantNetrc: `machine us-west1-go.pkg.dev
 login _json_key_base64
-password ewogICAgInRlc3Qta2V5IjogInRlc3QtdmFsdWUiCn0=
+password eyJ0ZXN0LWtleSI6ICJ0ZXN0LXZhbHVlIn0=
 `,
 		},
 		{
@@ -236,7 +236,10 @@ func TestLoad(t *testing.T) {
 	if err != nil {
 		t.Fatalf("os.Getwd() = %v", err)
 	}
-	testDataDir := path.Join(currentDir, "testdata", "load_test")
+
+	netrcFileName := getNetrcFileName()
+
+	testDataDir := filepath.Join(currentDir, "testdata", "load_test")
 
 	cases := []struct {
 		name             string
@@ -247,29 +250,29 @@ func TestLoad(t *testing.T) {
 	}{
 		{
 			name:             "NETRC env points to existing directory",
-			netrcPath:        path.Join(testDataDir, "empty_dir"),
-			wantNetrcPath:    path.Join(testDataDir, "empty_dir", ".netrc"),
+			netrcPath:        filepath.Join(testDataDir, "empty_dir"),
+			wantNetrcPath:    filepath.Join(testDataDir, "empty_dir", netrcFileName),
 			wantNetrcContent: "",
 			wantErr:          nil,
 		},
 		{
 			name:             "NETRC env points to non-existent directory",
-			netrcPath:        path.Join(testDataDir, "non_existent_dir"),
+			netrcPath:        filepath.Join(testDataDir, "non_existent_dir"),
 			wantNetrcPath:    "",
 			wantNetrcContent: "",
 			wantErr:          os.ErrNotExist,
 		},
 		{
 			name:             "NETRC env points to existing file",
-			netrcPath:        path.Join(testDataDir, "has_netrc_file_dir", ".netrc"),
-			wantNetrcPath:    path.Join(testDataDir, "has_netrc_file_dir", ".netrc"),
+			netrcPath:        filepath.Join(testDataDir, "has_netrc_file_dir", netrcFileName),
+			wantNetrcPath:    filepath.Join(testDataDir, "has_netrc_file_dir", netrcFileName),
 			wantNetrcContent: hasNetrcFileDirNetrcContent,
 			wantErr:          nil,
 		},
 		{
 			name:             "NETRC env points to non-existent file",
-			netrcPath:        path.Join(testDataDir, "empty_dir", ".netrc"),
-			wantNetrcPath:    path.Join(testDataDir, "empty_dir", ".netrc"),
+			netrcPath:        filepath.Join(testDataDir, "empty_dir", netrcFileName),
+			wantNetrcPath:    filepath.Join(testDataDir, "empty_dir", netrcFileName),
 			wantNetrcContent: "",
 			wantErr:          nil,
 		},

pkg/netrc/testdata/key.json

@@ -1,3 +1 @@
-{
-    "test-key": "test-value"
-}
+{"test-key": "test-value"}

pkg/netrc/testdata/load_test/has_netrc_file_dir/_netrc

@@ -0,0 +1,3 @@
+machine example.com
+login username
+password password