Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all non-major dependencies #329

Merged
merged 1 commit into from
Jan 3, 2025
Merged

Update all non-major dependencies #329

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -537,7 +537,7 @@
<dependency>
<groupId>org.checkerframework</groupId>
<artifactId>checker-qual</artifactId>
<version>3.48.3</version>
<version>3.48.4</version>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

Add a comment explaining the reason for this dependency update. Mentioning specific bug fixes or new features is helpful for future maintainers. This adheres to common style guide practices of commenting changes. I'm referencing a commonly used style guide, since none was explicitly provided.

Suggested change
<version>3.48.4</version>
<!-- Updating checker-qual to 3.48.4 for bug fixes. -->
<version>3.48.4</version>

<scope>provided</scope>
</dependency>
<dependency>
Expand Down Expand Up @@ -713,7 +713,7 @@
<dependency>
<groupId>org.mockito</groupId>
<artifactId>mockito-bom</artifactId>
<version>5.14.2</version>
<version>5.15.2</version>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

Similar to the previous comment, add a comment explaining the reason for updating mockito-bom. This improves maintainability and adheres to common style guide practices. I'm referencing a commonly used style guide, since none was explicitly provided.

Suggested change
<version>5.15.2</version>
<!-- Updating mockito-bom to 5.15.2 for javadoc fix. -->
<version>5.15.2</version>

<scope>import</scope>
<type>pom</type>
</dependency>
Expand Down
Loading