Skip to content

Commit

Permalink
addressed review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
srinjoyray committed Dec 18, 2024
1 parent af1f890 commit 61fedeb
Show file tree
Hide file tree
Showing 14 changed files with 18 additions and 17 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -83,22 +83,22 @@ public void testSendError() throws Exception {
String url = runtime.jettyUrl("/send-error");
ContentResponse response = httpClient.GET(url);
assertEquals(HttpStatus.OK_200, response.getStatus());
assertThat(response.getContentAsString(), containsString("<h1>Hello, world!</h1>"));
assertThat(response.getContentAsString(), containsString("<h1>Hello, welcome to App Engine Java Standard!</h1>"));

url = runtime.jettyUrl("/send-error?errorCode=404");
response = httpClient.GET(url);
assertEquals(HttpStatus.NOT_FOUND_404, response.getStatus());
assertThat(response.getContentAsString(), containsString("<h1>Error 404 Not Found</h1>"));
assertThat(response.getContentAsString(), containsString("<h1>404 - Page Not Found (App Engine Java Standard)</h1>"));

url = runtime.jettyUrl("/send-error?errorCode=500");
response = httpClient.GET(url);
assertEquals(HttpStatus.INTERNAL_SERVER_ERROR_500, response.getStatus());
assertThat(response.getContentAsString(), containsString("<h1>Error 500 Internal Server Error</h1>"));
assertThat(response.getContentAsString(), containsString("<h1>500 - Internal Server Error (App Engine Java Standard)</h1>"));

url = runtime.jettyUrl("/send-error?errorCode=503");
response = httpClient.GET(url);
assertEquals(HttpStatus.SERVICE_UNAVAILABLE_503, response.getStatus());
assertThat(response.getContentAsString(), containsString("<h1>Unhandled Error</h1>"));
assertThat(response.getContentAsString(), containsString("<h1>Unhandled Error - Service Temporarily Unavailable (App Engine Java Standard)</h1>"));

}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,4 @@
See the License for the specific language governing permissions and
limitations under the License.
-->
<h1>Error 404 Not Found</h1>
<h1>404 - Page Not Found (App Engine Java Standard)</h1>
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,4 @@
See the License for the specific language governing permissions and
limitations under the License.
-->
<h1>Error 500 Internal Server Error</h1>
<h1>500 - Internal Server Error (App Engine Java Standard)</h1>
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,4 @@
See the License for the specific language governing permissions and
limitations under the License.
-->
<h1>Hello, world!</h1>
<h1>Hello, welcome to App Engine Java Standard!</h1>
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,4 @@
See the License for the specific language governing permissions and
limitations under the License.
-->
<h1>Unhandled Error</h1>
<h1>Unhandled Error - Service Temporarily Unavailable (App Engine Java Standard)</h1>
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,4 @@
See the License for the specific language governing permissions and
limitations under the License.
-->
<h1>Error 404 Not Found</h1>
<h1>404 - Page Not Found (App Engine Java Standard)</h1>
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,4 @@
See the License for the specific language governing permissions and
limitations under the License.
-->
<h1>Error 500 Internal Server Error</h1>
<h1>500 - Internal Server Error (App Engine Java Standard)</h1>
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,4 @@
See the License for the specific language governing permissions and
limitations under the License.
-->
<h1>Hello, world!</h1>
<h1>Hello, welcome to App Engine Java Standard!</h1>
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,4 @@
See the License for the specific language governing permissions and
limitations under the License.
-->
<h1>Unhandled Error</h1>
<h1>Unhandled Error - Service Temporarily Unavailable (App Engine Java Standard)</h1>
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,4 @@
See the License for the specific language governing permissions and
limitations under the License.
-->
<h1>Error 404 Not Found</h1>
<h1>404 - Page Not Found (App Engine Java Standard)</h1>
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,4 @@
See the License for the specific language governing permissions and
limitations under the License.
-->
<h1>Error 500 Internal Server Error</h1>
<h1>500 - Internal Server Error (App Engine Java Standard)</h1>
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
<application>senderror</application>
<version>1</version>
<system-properties>
<property name="appengine.use.EE8" value="true"/>
<property name="appengine.use.EE8" value="false"/>
<property name="appengine.use.EE10" value="false"/>
</system-properties>
</appengine-web-app>
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,4 @@
See the License for the specific language governing permissions and
limitations under the License.
-->
<h1>Hello, world!</h1>
<h1>Hello, welcome to App Engine Java Standard!</h1>
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,4 @@
See the License for the specific language governing permissions and
limitations under the License.
-->
<h1>Unhandled Error</h1>
<h1>Unhandled Error - Service Temporarily Unavailable (App Engine Java Standard)</h1>

0 comments on commit 61fedeb

Please sign in to comment.