-
Notifications
You must be signed in to change notification settings - Fork 971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle extra columns present on Spanner #1995
Conversation
...in/java/com/google/cloud/teleport/v2/spanner/migrations/avro/GenericRecordTypeConvertor.java
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1995 +/- ##
============================================
+ Coverage 45.26% 52.86% +7.59%
+ Complexity 3632 1345 -2287
============================================
Files 836 372 -464
Lines 49872 20616 -29256
Branches 5253 2088 -3165
============================================
- Hits 22577 10898 -11679
+ Misses 25621 9041 -16580
+ Partials 1674 677 -997
|
...in/java/com/google/cloud/teleport/v2/spanner/migrations/avro/GenericRecordTypeConvertor.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also check if this works for the tokenList use case ?
...in/java/com/google/cloud/teleport/v2/spanner/migrations/avro/GenericRecordTypeConvertor.java
Outdated
Show resolved
Hide resolved
TOKENLIST is a new datatype in Spanner that is not handled here. That will be taken up in a follow up PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This PR supports Spanner having extra columns not present at source. Earlier, an additional column was a TODO, so apart from the shard id, extra cols would cause the transformation to error out. Additional columns on Spanner can be populated via
Testing
Unit Tests Added
Pending